From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932321AbcHOPNF (ORCPT ); Mon, 15 Aug 2016 11:13:05 -0400 Received: from pmta2.delivery5.ore.mailhop.org ([54.186.218.12]:39042 "EHLO pmta2.delivery5.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753020AbcHOPND (ORCPT ); Mon, 15 Aug 2016 11:13:03 -0400 X-MHO-User: f7b0e588-62fa-11e6-8929-8ded99d5e9d7 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 74.99.77.15 X-Mail-Handler: DuoCircle Outbound SMTP X-DKIM: OpenDKIM Filter v2.6.8 io 8562280071 Date: Mon, 15 Aug 2016 15:12:59 +0000 From: Jason Cooper To: Zubair Lutfullah Kakakhel Cc: monstr@monstr.eu, ralf@linux-mips.org, tglx@linutronix.de, marc.zyngier@arm.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 4/9] MIPS: xilfpga: Use Xilinx AXI Interrupt Controller Message-ID: <20160815151259.GC3353@io.lakedaemon.net> References: <1471269335-58747-1-git-send-email-Zubair.Kakakhel@imgtec.com> <1471269335-58747-5-git-send-email-Zubair.Kakakhel@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471269335-58747-5-git-send-email-Zubair.Kakakhel@imgtec.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Zubair, On Mon, Aug 15, 2016 at 02:55:30PM +0100, Zubair Lutfullah Kakakhel wrote: > IRQs from peripherals such as i2c/uart/ethernet come via > the AXI Interrupt controller. > > Select it in Kconfig for xilfpga and add the DT node > > Signed-off-by: Zubair Lutfullah Kakakhel > --- > arch/mips/Kconfig | 1 + > arch/mips/boot/dts/xilfpga/nexys4ddr.dts | 12 ++++++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 2638856..42ecf40 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -426,6 +426,7 @@ config MACH_XILFPGA > select SYS_SUPPORTS_ZBOOT_UART16550 > select USE_OF > select USE_GENERIC_EARLY_PRINTK_8250 > + select XILINX_IRQ > help > This enables support for the IMG University Program MIPSfpga platform. Please split dt changes from code changes. > diff --git a/arch/mips/boot/dts/xilfpga/nexys4ddr.dts b/arch/mips/boot/dts/xilfpga/nexys4ddr.dts > index 48d2112..8db660b 100644 > --- a/arch/mips/boot/dts/xilfpga/nexys4ddr.dts > +++ b/arch/mips/boot/dts/xilfpga/nexys4ddr.dts > @@ -17,6 +17,18 @@ > compatible = "mti,cpu-interrupt-controller"; > }; > > + axi_intc: interrupt-controller@10200000 { > + #interrupt-cells = <1>; > + compatible = "xlnx,xps-intc-1.00.a"; This compatible string isn't documented, mind adding it? Please make sure to Cc the devicetree maintainers on it. thx, Jason. > + interrupt-controller; > + reg = <0x10200000 0x10000>; > + xlnx,kind-of-intr = <0x0>; > + xlnx,num-intr-inputs = <0x6>; > + > + interrupt-parent = <&cpuintc>; > + interrupts = <6>; > + }; > + > axi_gpio: gpio@10600000 { > #gpio-cells = <1>; > compatible = "xlnx,xps-gpio-1.00.a"; > -- > 1.9.1 >