From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753147AbcHOPXA (ORCPT ); Mon, 15 Aug 2016 11:23:00 -0400 Received: from outbound1.eu.mailhop.org ([52.28.251.132]:47424 "EHLO outbound1.eu.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752850AbcHOPW6 (ORCPT ); Mon, 15 Aug 2016 11:22:58 -0400 X-MHO-User: 2bb2f200-62fc-11e6-ac92-3142cfe117f2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 74.99.77.15 X-Mail-Handler: DuoCircle Outbound SMTP X-DKIM: OpenDKIM Filter v2.6.8 io 50B7580064 Date: Mon, 15 Aug 2016 15:22:50 +0000 From: Jason Cooper To: Zubair Lutfullah Kakakhel Cc: monstr@monstr.eu, ralf@linux-mips.org, tglx@linutronix.de, marc.zyngier@arm.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/9] microblaze: irqchip: Move intc driver to irqchip Message-ID: <20160815152250.GE3353@io.lakedaemon.net> References: <1471269335-58747-1-git-send-email-Zubair.Kakakhel@imgtec.com> <1471269335-58747-2-git-send-email-Zubair.Kakakhel@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471269335-58747-2-git-send-email-Zubair.Kakakhel@imgtec.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Zubair, On Mon, Aug 15, 2016 at 02:55:27PM +0100, Zubair Lutfullah Kakakhel wrote: > The Xilinx AXI Interrupt Controller IP block is used by the MIPS > based xilfpga platform. > > Move the interrupt controller code out of arch/microblaze so that > it can be used by everyone > > Signed-off-by: Zubair Lutfullah Kakakhel > --- > arch/microblaze/Kconfig | 1 + > arch/microblaze/kernel/Makefile | 2 +- > drivers/irqchip/Kconfig | 4 ++++ > drivers/irqchip/Makefile | 1 + > arch/microblaze/kernel/intc.c => drivers/irqchip/irq-xilinx.c | 0 > 5 files changed, 7 insertions(+), 1 deletion(-) > rename arch/microblaze/kernel/intc.c => drivers/irqchip/irq-xilinx.c (100%) When you send the next version, please disable rename detection. The driver looks pretty straight forward, but I'd like to take the opportunity to clean up the abstraction around read and write. As well as making it easier for everyone to review on-list. thx, Jason.