From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753077AbcHOVbK (ORCPT ); Mon, 15 Aug 2016 17:31:10 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:35374 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752576AbcHOVbJ (ORCPT ); Mon, 15 Aug 2016 17:31:09 -0400 Date: Mon, 15 Aug 2016 23:30:59 +0200 From: Andrew Lunn To: Kedareswara rao Appana , David Miller Cc: robh+dt@kernel.org, mark.rutland@arm.com, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, appanad@xilinx.com, f.fainelli@gmail.com, punnaia@xilinx.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support Message-ID: <20160815213059.GK24664@lunn.ch> References: <1470735283-23611-1-git-send-email-appanad@xilinx.com> <1470735283-23611-4-git-send-email-appanad@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470735283-23611-4-git-send-email-appanad@xilinx.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Signed-off-by: Kedareswara rao Appana > --- > Thanks a lot Andrew for your inputs. > Changes for v5: > --> Fixed return values in the probe as suggested by punnaiah. > --> Added a mask for the converter speed as suggested by punnaiah. > +/* Xilinx GMII2RGMII Converter driver > + * > + * Copyright (C) 2016 Xilinx, Inc. > + * > + * Author: Kedareswara rao Appana Not cool https://github.com/lunn/linux/commit/03d375489ceb56e171056f44d0fe9c34ca5a098e Notice the Not-Signed-off-by: Andrew Lunn and the Copyright i added? In various emails i gave you the basic idea how this should be done, a framework of code, and then took your code which did not even compile and made the core of it work. This is as much my code as your code, so i expect my Copyright to be kept on this code. And since this is my code, i need to give a Signed-off-by, which i was not yet ready to give since the code was not complete or working. Please put both my Copyright back and Not-Signed-Off-by back and post the next version as RFC. Once i'm happy this code is O.K, i will give you a Signed-off-by. Andrew