From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932388AbcHOXAY (ORCPT ); Mon, 15 Aug 2016 19:00:24 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:35185 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932305AbcHOXAX (ORCPT ); Mon, 15 Aug 2016 19:00:23 -0400 Date: Mon, 15 Aug 2016 19:00:18 -0400 From: Tejun Heo To: Bhaktipriya Shridhar Cc: Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] android: binder: Remove deprecated create_singlethread_workqueue Message-ID: <20160815230018.GH3672@mtj.duckdns.org> References: <20160813164624.GA9414@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160813164624.GA9414@Karyakshetra> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 13, 2016 at 10:16:24PM +0530, Bhaktipriya Shridhar wrote: > The workqueue is being used to run deferred work for the android binder. > > The "binder_deferred_workqueue" queues only a single work item and hence > does not require ordering. Also, this workqueue is not being used on a > memory recliam path. Hence, the singlethreaded workqueue has been > replaced with the use of system_wq. > > System workqueues have been able to handle high level of concurrency > for a long time now and hence it's not required to have a singlethreaded > workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue > created with create_singlethread_workqueue(), system_wq allows multiple > work items to overlap executions even on the same CPU; however, a > per-cpu workqueue doesn't have any CPU locality or global ordering > guarantee unless the target CPU is explicitly specified and thus the > increase of local concurrency shouldn't make any difference. > > Signed-off-by: Bhaktipriya Shridhar Acked-by: Tejun Heo Thanks. -- tejun