From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753374AbcHPKtr (ORCPT ); Tue, 16 Aug 2016 06:49:47 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50218 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753384AbcHPKti (ORCPT ); Tue, 16 Aug 2016 06:49:38 -0400 Date: Tue, 16 Aug 2016 12:49:38 +0200 From: Greg Kroah-Hartman To: Valentin Rothberg Cc: Andrew Donnellan , LKML , josh@joshtriplett.org Subject: Re: [PATCH v2] checkkconfigsymbols.py: add --no-color option, don't print color to non-TTY Message-ID: <20160816104938.GB28337@kroah.com> References: <1467621570-970-1-git-send-email-andrew.donnellan@au1.ibm.com> <1467704857-831-1-git-send-email-andrew.donnellan@au1.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2016 at 10:25:48AM +0200, Valentin Rothberg wrote: > Hi Greg, > > could you pick up this patch? > > On Tue, Jul 5, 2016 at 9:47 AM, Andrew Donnellan > wrote: > > Only print the ANSI colour escape codes if stdout is a TTY. Useful if > > redirecting output to a file or piping to another script. > > > > Also add a new option, --no-color, if the user wants to disable colour > > output for whatever reason. > > > > Signed-off-by: Andrew Donnellan > > Acked-by: Valentin Rothberg It's in my very long "to-review" queue, it's not lost, just seems like it... thanks, greg k-h