From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753890AbcHPPaS (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Aug 2016 11:30:18 -0400
Received: from mail-pa0-f66.google.com ([209.85.220.66]:33728 "EHLO
	mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753788AbcHPPaQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Aug 2016 11:30:16 -0400
Date: Wed, 17 Aug 2016 00:28:47 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, Pekka Enberg <penberg@kernel.org>,
        Wang Nan <wangnan0@huawei.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf hists browser: remove superfluous null check on map
Message-ID: <20160816152847.GD11382@danjae.aot.lge.com>
References: <1471278343-14999-1-git-send-email-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1471278343-14999-1-git-send-email-colin.king@canonical.com>
User-Agent: Mutt/1.6.2 (2016-07-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 15, 2016 at 05:25:43PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> map is being already checked if it is null at the start of
> do_zoom_dso, so the second subsequent check is superfluous
> and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


> ---
>  tools/perf/ui/browsers/hists.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> index 13d4143..8d72939 100644
> --- a/tools/perf/ui/browsers/hists.c
> +++ b/tools/perf/ui/browsers/hists.c
> @@ -2418,8 +2418,6 @@ do_zoom_dso(struct hist_browser *browser, struct popup_action *act)
>  		browser->hists->dso_filter = NULL;
>  		ui_helpline__pop();
>  	} else {
> -		if (map == NULL)
> -			return 0;
>  		ui_helpline__fpush("To zoom out press ESC or ENTER + \"Zoom out of %s DSO\"",
>  				   __map__is_kernel(map) ? "the Kernel" : map->dso->short_name);
>  		browser->hists->dso_filter = map->dso;
> -- 
> 2.8.1
>