mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: RFC: callchain showing same entry as hist_entry
Date: Wed, 17 Aug 2016 00:41:18 +0900	[thread overview]
Message-ID: <20160816154118.GE11382@danjae.aot.lge.com> (raw)
In-Reply-To: <20160816153244.GK20972@kernel.org>

On Tue, Aug 16, 2016 at 12:32:44PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Aug 16, 2016 at 12:31:43PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Wed, Aug 17, 2016 at 12:23:55AM +0900, Namhyung Kim escreveu:
> > > Did you run 'perf report -s sym --stdio'?  It seems that current code
> > > already works as sane..  Do you want to make it work for the default sort
> > >> key too?
> > 
> > What I want is not to repeat the hist_entry line as the first entry in
> > the callchain, which is confusing.
> > 
> > I.e. repeat the duplication that is happening with the default sort
> 
> s/repeat/remove/g
> 
> > entry, that contains "sym".

Hmm.. if so, wouldn't it be better skipping the first callchain entry
when the user-given sort key contains "sym" too (not only when it
starts with 'sym')?

Thanks,
Namhyung

  reply	other threads:[~2016-08-16 15:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-16 14:36 Arnaldo Carvalho de Melo
2016-08-16 14:50 ` Jiri Olsa
2016-08-16 14:55 ` Namhyung Kim
2016-08-16 15:08   ` Arnaldo Carvalho de Melo
2016-08-16 15:23     ` Namhyung Kim
2016-08-16 15:31       ` Arnaldo Carvalho de Melo
2016-08-16 15:32         ` Arnaldo Carvalho de Melo
2016-08-16 15:41           ` Namhyung Kim [this message]
2016-08-16 15:46             ` Arnaldo Carvalho de Melo
2016-08-16 19:21               ` Arnaldo Carvalho de Melo
2016-08-19  2:20                 ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160816154118.GE11382@danjae.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=arnaldo.melo@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®