From: Mark Brown <broonie@kernel.org>
To: Vignesh R <vigneshr@ti.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v5] spi: spi-ti-qspi: Add DMA support for QSPI mmap read
Date: Tue, 16 Aug 2016 19:42:53 +0100 [thread overview]
Message-ID: <20160816184253.GC9347@sirena.org.uk> (raw)
In-Reply-To: <13e676c2-7e2f-d1c5-5312-bc2e11a6b6a1@ti.com>
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
On Tue, Aug 09, 2016 at 06:20:01PM +0530, Vignesh R wrote:
>
>
> According to this thread[1], converting virtual address
> pointer into scatterlist which is then DMA mapped is unsafe on systems
> with certain cache architecture. Hence, I added code to handle kmap
> buffers inside the driver rather than updating generic spi-core code.
That's saying that things that aren't covered aren't DMAable safely at
all which is a more general issue...
> If its okay to update the spi_map_buf() to handle kmap buffers as above
> then I can submit the patch accordingly.
Yes, the whole point is that this is all in generic code so drivers
don't need to worry about it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-08-16 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 11:03 Vignesh R
2016-08-09 11:33 ` Mark Brown
2016-08-09 12:50 ` Vignesh R
2016-08-16 18:42 ` Mark Brown [this message]
2016-08-17 5:13 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816184253.GC9347@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®