From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753402AbcHPTNy (ORCPT ); Tue, 16 Aug 2016 15:13:54 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:39548 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752053AbcHPTNw (ORCPT ); Tue, 16 Aug 2016 15:13:52 -0400 Date: Tue, 16 Aug 2016 20:13:38 +0100 From: Russell King - ARM Linux To: Geert Uytterhoeven Cc: Arnd Bergmann , Joe Perches , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: Add missing newline terminators to kernel messages Message-ID: <20160816191338.GL1041@n2100.armlinux.org.uk> References: <1471354832-18456-1-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471354832-18456-1-git-send-email-geert+renesas@glider.be> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2016 at 03:40:32PM +0200, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > Before commit 874f9c7da9a4acbc ("printk: create pr_ functions"), > pr_*() calls without a trailing newline characters would be printed with > a newline character appended, both on the console and in the output of > the dmesg command. > > After that commit, no new line character is appended, and the output of > the next pr_*() call of the same type may be appended: > > - Truncating RAM at 0x0000000040000000-0x00000000c0000000 to -0x0000000070000000 > - Ignoring RAM at 0x0000000200000000-0x0000000240000000 (!CONFIG_HIGHMEM) > + Truncating RAM at 0x0000000040000000-0x00000000c0000000 to -0x0000000070000000Ignoring RAM at 0x0000000200000000-0x0000000240000000 (!CONFIG_HIGHMEM) > > and: > > -No ATAGs? > -hw-breakpoint: found 5 (+1 reserved) breakpoint and 4 watchpoint registers. > +No ATAGs?hw-breakpoint: found 5 (+1 reserved) breakpoint and 4 watchpoint registers. > > While this commit has been reverted in commit a0cba2179ea4c182 ("Revert > "printk: create pr_ functions""), it's still good practice to > terminate kernel messages with newlines. Shouldn't that be above the "---" line? Other than that, patch looks fine, thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.