From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945901AbcHQXn0 (ORCPT ); Wed, 17 Aug 2016 19:43:26 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:33264 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752797AbcHQXnY (ORCPT ); Wed, 17 Aug 2016 19:43:24 -0400 Date: Wed, 17 Aug 2016 19:34:26 -0400 (EDT) Message-Id: <20160817.193426.2273185535811000291.davem@davemloft.net> To: thierry.reding@gmail.com Cc: u.kleine-koenig@pengutronix.de, geert+renesas@glider.be, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ipconfig: Fix more use after free From: David Miller In-Reply-To: <20160816144538.3181-1-thierry.reding@gmail.com> References: <20160816144538.3181-1-thierry.reding@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 17 Aug 2016 16:34:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thierry Reding Date: Tue, 16 Aug 2016 16:45:38 +0200 > From: Thierry Reding > > While commit 9c706a49d660 ("net: ipconfig: fix use after free") avoids > the use after free, the resulting code still ends up calling both the > ic_setup_if() and ic_setup_routes() after calling ic_close_devs(), and > access to the device is still required. > > Move the call to ic_close_devs() to the very end of the function. > > Signed-off-by: Thierry Reding > --- > This applies on top of next-20160816. Applied, thanks.