mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: Alex Thorlton <athorlton@sgi.com>
Cc: Borislav Petkov <bp@alien8.de>,
	Matt Fleming <matt@codeblueprint.co.uk>,
	linux-kernel@vger.kernel.org, Russ Anderson <rja@sgi.com>,
	Dimitri Sivanich <sivanich@sgi.com>, Mike Travis <travis@sgi.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-efi@vger.kernel.org
Subject: Re: [PATCH] Map in physical addresses in efi_map_region_fixed
Date: Wed, 17 Aug 2016 15:01:51 +0800	[thread overview]
Message-ID: <20160817070151.GC5498@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <20160815184731.GS214806@stormcage.americas.sgi.com>

> > Why do you guys need the physical mapping all of a sudden?
> 
> It's not that we need it all of the sudden, necessarily, it's just that
> we've had to make other changes to make things work with the new,
> (almost) completely isolated, EFI page tables.  We ended up choosing the
> lesser of two evils, and have decided to temporarily rely on the
> physical address of our runtime code, instead of continuing to rely on
> EFI_OLD_MEMMAP.

In efi_map_region, there is already mapped md->phys_addr for broken
firmware. SGI still need EFI_OLD_MEMMAP? I means in 1st kernel instead
of kexec kernel.

void __init efi_map_region(efi_memory_desc_t *md)
{
        unsigned long size = md->num_pages << PAGE_SHIFT;
        u64 pa = md->phys_addr;

        if (efi_enabled(EFI_OLD_MEMMAP))
                return old_map_region(md);

        /*
         * Make sure the 1:1 mappings are present as a catch-all for
         * b0rked
         * firmware which doesn't update all internal pointers after
         * switching
         * to virtual mode and would otherwise crap on us.
         */
        __map_region(md, md->phys_addr);

[snip]

Thanks
Dave

  parent reply	other threads:[~2016-08-17  7:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-05 23:59 Alex Thorlton
2016-08-10 17:19 ` Alex Thorlton
2016-08-15 12:42 ` Matt Fleming
2016-08-15 15:07   ` Borislav Petkov
2016-08-15 18:47     ` Alex Thorlton
2016-08-15 21:52       ` H. Peter Anvin
2016-08-16  5:38         ` Borislav Petkov
2016-08-16  5:50       ` Borislav Petkov
2016-08-16 15:25         ` Alex Thorlton
2016-08-17  7:01       ` Dave Young [this message]
2016-08-17 16:00         ` Alex Thorlton
2016-08-18  6:11           ` Dave Young
2016-08-16 12:30     ` Matt Fleming
2016-08-16 13:29       ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160817070151.GC5498@dhcp-128-65.nay.redhat.com \
    --to=dyoung@redhat.com \
    --cc=athorlton@sgi.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=mingo@redhat.com \
    --cc=rja@sgi.com \
    --cc=sivanich@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=travis@sgi.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®