From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753669AbcHQLRR (ORCPT ); Wed, 17 Aug 2016 07:17:17 -0400 Received: from mga04.intel.com ([192.55.52.120]:57922 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753508AbcHQLRP (ORCPT ); Wed, 17 Aug 2016 07:17:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,529,1464678000"; d="scan'208";a="1037065969" Date: Wed, 17 Aug 2016 14:17:05 +0300 From: Heikki Krogerus To: Tal Shorer Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, balbi@kernel.org Subject: Re: [PATCH v3 8/8] usb: dwc3: ulpi: make dwc3_ulpi_ops constant Message-ID: <20160817111705.GQ9927@kuha.fi.intel.com> References: <1471363493-7836-1-git-send-email-tal.shorer@gmail.com> <1471363493-7836-9-git-send-email-tal.shorer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471363493-7836-9-git-send-email-tal.shorer@gmail.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2016 at 07:04:53PM +0300, Tal Shorer wrote: > ulpi_register_interface() accepts a const struct ulpi_ops and dwc3 > doesn't perform any changes to this struct at runtime, so there's no > reason it shouldn't be constant. > > Signed-off-by: Tal Shorer Reviewed-by: Heikki Krogerus Thanks, -- heikki