From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754295AbcHSERM (ORCPT ); Fri, 19 Aug 2016 00:17:12 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:41879 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752430AbcHSERK (ORCPT ); Fri, 19 Aug 2016 00:17:10 -0400 Date: Thu, 18 Aug 2016 21:16:55 -0700 (PDT) Message-Id: <20160818.211655.897588198741403986.davem@davemloft.net> To: ddaney.cavm@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sgoutham@cavium.com, rric@kernel.org, linux-arm-kernel@lists.infradead.org, david.daney@cavium.com, stable@vger.kernel.org Subject: Re: [PATCH] net: thunderx: Fix OOPs with ethtool --register-dump From: David Miller In-Reply-To: <1471375697-1878-1-git-send-email-ddaney.cavm@gmail.com> References: <1471375697-1878-1-git-send-email-ddaney.cavm@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 Aug 2016 21:16:56 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Daney Date: Tue, 16 Aug 2016 12:28:17 -0700 > From: David Daney > > The ethtool_ops .get_regs function attempts to read the nonexistent > register NIC_QSET_SQ_0_7_CNM_CHG, which produces a "bus error" type > OOPs. > > Fix by not attempting to read, and removing the definition of, > NIC_QSET_SQ_0_7_CNM_CHG. A zero is written into the register dump to > keep the layout unchanged. > > Signed-off-by: David Daney Applied.