From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754395AbcHSGhT (ORCPT ); Fri, 19 Aug 2016 02:37:19 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:42452 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752936AbcHSGhR (ORCPT ); Fri, 19 Aug 2016 02:37:17 -0400 Date: Thu, 18 Aug 2016 23:36:29 -0700 (PDT) Message-Id: <20160818.233629.2247737263787094338.davem@davemloft.net> To: zajec5@gmail.com Cc: netdev@vger.kernel.org, rafal@milecki.pl, f.fainelli@gmail.com, jon.mason@broadcom.com, arnd@arndb.de, tremyfr@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: bgmac: make it clear when setting interface type to RMII From: David Miller In-Reply-To: <1471468315-20574-1-git-send-email-zajec5@gmail.com> References: <1471468315-20574-1-git-send-email-zajec5@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=euc-kr Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 Aug 2016 23:36:30 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rafaİİ Miİİecki Date: Wed, 17 Aug 2016 23:11:52 +0200 > From: Rafaİİ Miİİecki > > It doesn't really change anything as BGMAC_CHIPCTL_1_IF_TYPE_RMII is > equal to 0. It make code a bit clener, so far when reading it one could > think we forgot to set a proper mode. It also keeps this mode code in > sync with other ones. > > Signed-off-by: Rafaİİ Miİİecki Applied.