From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932417AbcHSBkg (ORCPT ); Thu, 18 Aug 2016 21:40:36 -0400 Received: from tex.lwn.net ([70.33.254.29]:34739 "EHLO vena.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753233AbcHSBjg (ORCPT ); Thu, 18 Aug 2016 21:39:36 -0400 Date: Thu, 18 Aug 2016 11:08:51 -0600 From: Jonathan Corbet To: Ricardo Ribalda Delgado Cc: Greg Kroah-Hartman , Jiri Slaby , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Documentation: rs485: Do not define manually the ioctl Message-ID: <20160818110851.04bc0ab5@lwn.net> In-Reply-To: <1471510459-8142-1-git-send-email-ricardo.ribalda@gmail.com> References: <1471510459-8142-1-git-send-email-ricardo.ribalda@gmail.com> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Aug 2016 10:54:19 +0200 Ricardo Ribalda Delgado wrote: > It is not a very good practice to define the IOCTL manually instead of > using the header file. > > Fix it on the documentation example. Makes sense to me; applied to the docs tree, thanks. jon