From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753530AbcHTFpZ (ORCPT ); Sat, 20 Aug 2016 01:45:25 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:57183 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164AbcHTFpY (ORCPT ); Sat, 20 Aug 2016 01:45:24 -0400 Date: Fri, 19 Aug 2016 22:44:53 -0700 (PDT) Message-Id: <20160819.224453.463393161743242538.davem@davemloft.net> To: skhare@vmware.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, pv-drivers@vmware.com, gyang@vmware.com Subject: Re: [PATCH net] vmxnet3: fix tx data ring copy for variable size From: David Miller In-Reply-To: <1471628022-93931-1-git-send-email-skhare@vmware.com> References: <1471628022-93931-1-git-send-email-skhare@vmware.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 19 Aug 2016 22:44:53 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shrikrishna Khare Date: Fri, 19 Aug 2016 10:33:42 -0700 > 'Commit 3c8b3efc061a ("vmxnet3: allow variable length transmit data ring > buffer")' changed the size of the buffers in the tx data ring from a > fixed size of 128 bytes to a variable size. > > However, while copying data to the data ring, vmxnet3_copy_hdr continues > to carry the old code that assumes fixed buffer size of 128. This patch > fixes it by adding correct offset based on the actual data ring buffer > size. > > Signed-off-by: Guolin Yang > Signed-off-by: Shrikrishna Khare Applied.