From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932203AbcHSOxb convert rfc822-to-8bit (ORCPT ); Fri, 19 Aug 2016 10:53:31 -0400 Received: from smtprelay0145.hostedemail.com ([216.40.44.145]:40834 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755199AbcHSOxa (ORCPT ); Fri, 19 Aug 2016 10:53:30 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1513:1515:1516:1518:1521:1534:1541:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3873:3874:4250:5007:6261:6691:7875:7903:8660:10004:10400:10848:10967:11026:11232:11473:11658:11914:12296:12438:12517:12519:12679:12740:13069:13148:13230:13311:13357:13439:14096:14097:14181:14659:14721:21080:21324:21433:30006:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: spy50_71ec4016cf31a X-Filterd-Recvd-Size: 2312 Date: Fri, 19 Aug 2016 10:26:20 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Clark Williams , Thomas Gleixner , Jon Masters , Daniel Wagner , Carsten Emde , Sebastian Andrzej Siewior Subject: Re: [PATCH v2 0/4] tracing: Add Hardware Latency detector tracer Message-ID: <20160819102620.763bd7a0@gandalf.local.home> In-Reply-To: <20160819140928.GK10121@twins.programming.kicks-ass.net> References: <20160810135356.265780824@goodmis.org> <20160819140928.GK10121@twins.programming.kicks-ass.net> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 Aug 2016 16:09:28 +0200 Peter Zijlstra wrote: > On Wed, Aug 10, 2016 at 09:53:56AM -0400, Steven Rostedt wrote: > > Changes since v1: > > > > . Added checks for CONFIG_GENERIC_SCHED_CLOCK, and if that is set, > > only nmi_counts will be recorded when an NMI is triggered, but not > > the time in NMI, because the generic sched_clock is not NMI safe. > > (suggested by Sebastian Andrzej Siewior) > > So any of the platforms using GENERIC_SCHED_CLOCK _have_ NMIs ? >>From what I gather, the answer is no, so I don't think this is an issue. > > In any case, for those you could probably use ktime_get_mono_fast_ns(). Is that safe to call from NMI? Looking into the code I see: now = ktime_to_ns(tkr->base) + timekeeping_get_ns(tkr); where timekeeping_get_ns() has: timekeeping_get_delta() which does: read_seqcount_begin() which has (eventually): repeat: ret = READ_ONCE(s->sequence); if (unlikely(ret & 1)) { cpu_relax(); goto repeat; } return ret; Which I think could cause a deadlock from an NMI. -- Steve