From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755344AbcHSUDC (ORCPT ); Fri, 19 Aug 2016 16:03:02 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:34945 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754140AbcHSUC7 (ORCPT ); Fri, 19 Aug 2016 16:02:59 -0400 Date: Fri, 19 Aug 2016 13:02:32 -0700 From: Darren Hart To: Peter Feuerer Cc: Baole Ni , david.vrabel@citrix.com, jgross@suse.com, bhelgaas@google.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com Subject: Re: [PATCH 0841/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160819200232.GE81374@f23x64.localdomain> References: <20160802115136.6059-1-baolex.ni@intel.com> <95991cb563633df910245c1fa8d83169@mail.piie.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <95991cb563633df910245c1fa8d83169@mail.piie.net> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 11, 2016 at 09:21:48PM +0000, Peter Feuerer wrote: > 2. August 2016 14:29 Uhr, "Baole Ni" schrieb: > > I find that the developers often just specified the numeric value > > when calling a macro which is defined with a parameter for access permission. > > As we know, these numeric value for access permission have had the corresponding macro, > > and that using macro can improve the robustness and readability of the code, > > thus, I suggest replacing the numeric parameter with the macro. > > > > Signed-off-by: Chuansheng Liu > > Signed-off-by: Baole Ni > > Acked-by: Peter Feuerer Due to objections elsewhere in the platform drivers subsystem, I have rejected these patches as a group, leaving it to the authors to make the argument for inclusion if they disagree with the decision. -- Darren Hart Intel Open Source Technology Center