From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933101AbcHUPgD (ORCPT <rfc822;w@1wt.eu>);
        Sun, 21 Aug 2016 11:36:03 -0400
Received: from imap.thunk.org ([74.207.234.97]:49762 "EHLO imap.thunk.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933073AbcHUPf4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 21 Aug 2016 11:35:56 -0400
Date: Sun, 21 Aug 2016 11:35:47 -0400
From: "Theodore Ts'o" <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] Add dockerfile
Message-ID: <20160821153547.3shrny7phed22xew@thunk.org>
Mail-Followup-To: Theodore Ts'o <tytso@mit.edu>,
        Dmitry Monakhov <dmonakhov@openvz.org>,
        linux-kernel@vger.kernel.org
References: <1471553651-9547-1-git-send-email-dmonakhov@openvz.org>
 <1471553651-9547-7-git-send-email-dmonakhov@openvz.org>
 <20160819052106.GC10888@thunk.org>
 <87eg5l6rcg.fsf@openvz.org>
 <20160819232953.GB12834@thunk.org>
 <87lgzrptgx.fsf@openvz.org>
 <20160820194530.GA9693@thunk.org>
 <87y43ql481.fsf@openvz.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87y43ql481.fsf@openvz.org>
User-Agent: Mutt/1.6.2-neo (2016-07-23)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: tytso@thunk.org
X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Aug 21, 2016 at 03:02:38PM +0300, Dmitry Monakhov wrote:
> Probably it it reasonable to create dedicated directory ./docker
> and place all docker related crap there:
> # build scripts
> docker/Dockerfile.build-env
> docker/Dockerfile.run-env
> # And some run scripts
> # Build all environment from scratch
> docker/docker-build.sh
> # Move config, kernel, root_fs.img inside container and run {gce,kvm}-xfstests.sh
> docker/docker-kvm-xfstests.sh 
> docker/docker-gce-xfstests.sh

I thought about that, but my current thinking is to have one
Dockerfile which is in the top-level directory, and one which is in
the kvm-xfstests directory.

I've already created a tytso/xfststs-bld Docker image which was
generated using:

docker build -t tytso/xfstests-bld https://github.com/tytso/xfstests-bld.git

By putting the Dockerfile in the top-level directory, I can use the
command "COPY . /devel/xfstests-bld" in the Dockerfile, and so we can
get a clean build build that way.

By putting a Dockerfile in the kvm-xfstests directory, then all I have
to do is to put a "COPY . /usr/local/lib/kvm-xfstests" which will copy
all of the kvm-xfstests directory directly where we want the files in
the kvm-xfstests Docker image.  I'm assuming that my release process
will first build root_fs.i386 and root_fs.x86_64 using debian chroots,
and then upload them to www.kernel.org.  I'll then run:

docker build -t tytso/kvm-xfstests https://github.com/tytso/xfstests-bld.git:kvm-xfstests

... and then the Dockerfile will pull the root_fs.i386 from
ftp.kernel.org.

What do you think?

						- Ted