From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756518AbcHVX0t (ORCPT ); Mon, 22 Aug 2016 19:26:49 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:46655 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756302AbcHVX0r (ORCPT ); Mon, 22 Aug 2016 19:26:47 -0400 Date: Mon, 22 Aug 2016 16:26:41 -0700 (PDT) Message-Id: <20160822.162641.227249250583935243.davem@davemloft.net> To: stephen@networkplumber.org Cc: mikko.rapeli@iki.fi, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v05 21/72] include/uapi/linux/if_pppox.h: include linux/if.h From: David Miller In-Reply-To: <20160822123745.7921a88d@xeon-e3> References: <1471890809-4383-1-git-send-email-mikko.rapeli@iki.fi> <1471890809-4383-22-git-send-email-mikko.rapeli@iki.fi> <20160822123745.7921a88d@xeon-e3> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 22 Aug 2016 16:26:42 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephen Hemminger Date: Mon, 22 Aug 2016 12:37:45 -0700 > It seems your goal is that every include file should be standalone, > i.e it must include every definition it uses. I think this is absolutely mandatory Stephen. If you include x.h it should just work if you use the interfaces x.h defines. No user should have to know about dependencies, that is exactly the job of the header file itself.