From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933164AbcHVXak (ORCPT ); Mon, 22 Aug 2016 19:30:40 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:46718 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753060AbcHVXai (ORCPT ); Mon, 22 Aug 2016 19:30:38 -0400 Date: Mon, 22 Aug 2016 16:30:32 -0700 (PDT) Message-Id: <20160822.163032.1005091075765531174.davem@davemloft.net> To: mikko.rapeli@iki.fi Cc: linux-kernel@vger.kernel.org, zhangshengju@cmss.chinamobile.com Subject: Re: [PATCH v05 27/72] linux/if.h linux/hdlc/ioctl.h: move IFNAMSIZ definition to hdlc/ioctl.h From: David Miller In-Reply-To: <1471890809-4383-28-git-send-email-mikko.rapeli@iki.fi> References: <1471890809-4383-1-git-send-email-mikko.rapeli@iki.fi> <1471890809-4383-28-git-send-email-mikko.rapeli@iki.fi> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 22 Aug 2016 16:30:33 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u7MNUiIA019155 From: Mikko Rapeli Date: Mon, 22 Aug 2016 20:32:44 +0200 > Fixes userspace compiler error: > > error: ĦIFNAMSIZ˘ undeclared here (not in a function) > > Suggested by Frans Klaver on lkml message > <20150530195223.GA15645@bugger.home>. > > Signed-off-by: Mikko Rapeli IFNAMSIZ has to be in linux/if.h, you aren't explaining why you have to move it to the hdlc header instead of having the hdlc header include linux/if.h And if your reason is legitimate, you have to add that explanation to the patch commit log message.