From: Thierry Reding <treding@nvidia.com>
To: Guodong Xu <guodong.xu@linaro.org>
Cc: <catalin.marinas@arm.com>, <will.deacon@arm.com>, <arnd@arndb.de>,
<horms+renesas@verge.net.au>, <olof@lixom.net>,
<kuninori.morimoto.gx@renesas.com>, <alim.akhtar@samsung.com>,
<srinivas.kandagatla@linaro.org>, <xuwei5@hisilicon.com>,
<khilman@baylibre.com>, <riku.voipio@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Xinliang Liu <xinliang.liu@linaro.org>
Subject: Re: [PATCH 2/4] arm64: defconfig: Set cma heap size to 128MB
Date: Mon, 22 Aug 2016 11:06:01 +0200 [thread overview]
Message-ID: <20160822090600.GB25947@ulmo.ba.sec> (raw)
In-Reply-To: <1471621328-21102-3-git-send-email-guodong.xu@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
On Fri, Aug 19, 2016 at 11:42:06PM +0800, Guodong Xu wrote:
> From: Xinliang Liu <xinliang.liu@linaro.org>
>
> For debian linux, cma heap is used to allocate graphic buffers.
> The default size is 16 MB which is not enought.
> So increase the size to 128 MB.
>
> Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
> ---
> arch/arm64/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
This is a bad idea. You're increasing this heap for all users of the
default configuration (which on 64-bit ARM is everyone, really). Many of
the devices don't require the CMA except maybe for the occasional very
small buffer. Most implement some form of IOMMU support that removes the
need for large amounts of contiguous physical memory.
I think it's a better idea to have some bootloader append a cma=128 to
the kernel command-line if necessary.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-22 9:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 15:42 [PATCH 0/4] arm64: defconfig: enable various configs for HiKey Guodong Xu
2016-08-19 15:42 ` [PATCH 1/4] arm64: defconfig: Enable HiSilicon kirin drm, adv7533 " Guodong Xu
2016-08-19 15:42 ` [PATCH 2/4] arm64: defconfig: Set cma heap size to 128MB Guodong Xu
2016-08-22 9:06 ` Thierry Reding [this message]
2016-08-24 2:23 ` Guodong Xu
2016-08-19 15:42 ` [PATCH 3/4] arm64: defconfig: enable CONFIG_INPUT_HISI_POWERKEY for HiKey Guodong Xu
2016-08-19 15:42 ` [PATCH 4/4] arm64: defconfig: enable bluetooth supports as modules Guodong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822090600.GB25947@ulmo.ba.sec \
--to=treding@nvidia.com \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=guodong.xu@linaro.org \
--cc=horms+renesas@verge.net.au \
--cc=khilman@baylibre.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=riku.voipio@linaro.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=will.deacon@arm.com \
--cc=xinliang.liu@linaro.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®