From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754836AbcHVJQq (ORCPT ); Mon, 22 Aug 2016 05:16:46 -0400 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:60122 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbcHVJQp (ORCPT ); Mon, 22 Aug 2016 05:16:45 -0400 Date: Mon, 22 Aug 2016 10:16:32 +0100 From: One Thousand Gnomes To: Daniel Vetter Cc: Heinrich Schuchardt , Patrik Jakobsson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/gma500: dont expose bytes from kernel stack Message-ID: <20160822101632.5c8f9ccb@lxorguk.ukuu.org.uk> In-Reply-To: <20160822072917.GD6232@phenom.ffwll.local> References: <1471804778-3656-1-git-send-email-xypron.glpk@gmx.de> <20160822072917.GD6232@phenom.ffwll.local> Organization: Intel Corporation X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Aug 2016 09:29:17 +0200 Daniel Vetter wrote: > On Sun, Aug 21, 2016 at 08:39:38PM +0200, Heinrich Schuchardt wrote: > > Components m1, m2, p2, dot, vco of variable clock should be > > initialized to avoid bytes from the kernel stack to be > > exposed. > > > > Signed-off-by: Heinrich Schuchardt > > Might be a silly question, but where exactly would we expose these bytes? > This isn't directly called by an ioctl, I have no idea how those bytes > might get to userspace ... mrst_print_pll displays clock.p2 - which is indeed never cleared 8) Alan