From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756030AbcHVQxU (ORCPT <rfc822;w@1wt.eu>);
        Mon, 22 Aug 2016 12:53:20 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35190 "EHLO
        mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752364AbcHVQxS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 Aug 2016 12:53:18 -0400
Date: Mon, 22 Aug 2016 17:52:59 +0100
From: Mark Brown <broonie@kernel.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Message-ID: <20160822165259.GS22076@sirena.org.uk>
References: <20160821021125.1521-1-wens@csie.org>
 <20160821021125.1521-5-wens@csie.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="o/5eNASeIIpuMggS"
Content-Disposition: inline
In-Reply-To: <20160821021125.1521-5-wens@csie.org>
X-Cookie: Satire is what closes in New Haven.
User-Agent: Mutt/1.6.0 (2016-04-01)
X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH 4/9] regulator: axp20x: support AXP806 variant
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--o/5eNASeIIpuMggS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Aug 21, 2016 at 10:11:20AM +0800, Chen-Yu Tsai wrote:

> +	if (id == AXP806_DCDCB) {
> +		return (((reg & GENMASK(7, 6)) == BIT(6)) ||
> +			((reg & GENMASK(7, 6)) == BIT(7)));
> +	} else if (id == AXP806_DCDCC) {
> +		return ((reg & GENMASK(7, 6)) == BIT(7));
> +	} else if (id == AXP806_DCDCE) {
> +		return !!(reg & BIT(5));
> +	}

This looks like you're trying to write a switch statement, please do
that.

--o/5eNASeIIpuMggS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJXuy3qAAoJECTWi3JdVIfQNk0H/1Gx2csm6YBGadyDxZtwhvHj
FOKf5b5z4Dk1+sFMznUNZ8HsK1G0pgyDhdnNp+m14y0GCt6VUuSGmoYZCoCxVXKI
7c66lcTMXcBTIrLeFBzb4rUdwg4hw4Xpt0Cxgeti4fMR31JfeHT1kpD8zo6vNhdk
w/29wVUZHE5pU0hn8n4V1MBW5gUWtjyaX/+8Cu9PMqojEjOyzDn7pmeZef8MBs35
RTnmMgwksHeW/zIoRvIfXaZ6voLMUSQxvl3n39G0G3HSFAX0MuT/q9hFzcwP2uxr
Se4dK63uH1/V6XZTtHiUcmdRK2Tzd82yNIbL23y9DU74cPK0mm3oWgwDTJu3lDU=
=RcA4
-----END PGP SIGNATURE-----

--o/5eNASeIIpuMggS--