From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757336AbcHWIHP (ORCPT ); Tue, 23 Aug 2016 04:07:15 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33171 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752596AbcHWIHL (ORCPT ); Tue, 23 Aug 2016 04:07:11 -0400 Date: Tue, 23 Aug 2016 13:37:00 +0530 From: Sudip Mukherjee To: dingxiang Cc: arnaud.patard@rtp-net.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging:xgifb:remove unused code Message-ID: <20160823080700.GA9280@sudip-laptop> References: <1471936942-15631-1-git-send-email-dingxiang@huawei.com> <57BBFABA.9070300@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57BBFABA.9070300@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 23, 2016 at 03:26:50PM +0800, dingxiang wrote: > The variable data is assigned but never used in rest code. > > Signed-off-by: Ding Xiang > --- Your name in Signed-off-by: and From: doesnot match. > drivers/staging/xgifb/vb_setmode.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c > index 50c8ea4..71bb9ca 100644 > --- a/drivers/staging/xgifb/vb_setmode.c > +++ b/drivers/staging/xgifb/vb_setmode.c > @@ -727,7 +727,6 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex, > tempax |= 0x40; > xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax); > - data = xgifb_reg_get(pVBInfo->P3d4, 0x07); > tempax = 0; > if (tempbx & 0x04) The patch will not apply. Its missing two blank lines which the original code has. regards sudip