From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757121AbcHWIpm (ORCPT <rfc822;w@1wt.eu>);
        Tue, 23 Aug 2016 04:45:42 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:50720 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753561AbcHWIpi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 23 Aug 2016 04:45:38 -0400
Date: Tue, 23 Aug 2016 10:45:19 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: Huang Rui <ray.huang@amd.com>, linux-kernel@vger.kernel.org,
        Borislav Petkov <bp@suse.de>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: perf: fuzzer crashes immediately on AMD system
Message-ID: <20160823084519.GN10153@twins.programming.kicks-ass.net>
References: <alpine.DEB.2.20.1608181025160.19862@macbook-air>
 <alpine.DEB.2.20.1608181046120.19862@macbook-air>
 <20160819100130.GD10121@twins.programming.kicks-ass.net>
 <20160822111631.GA25844@hr-amur2>
 <alpine.DEB.2.20.1608222057360.29115@macbook-air>
 <alpine.DEB.2.20.1608222250120.29115@macbook-air>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1608222250120.29115@macbook-air>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 22, 2016 at 10:54:32PM -0400, Vince Weaver wrote:
> > > > > 
> > > > > 	perf stat -a -e amd_nb/config=0x37,config1=0x20/ /bin/ls
> > 	amd_uncore_find_online_sibling()
> > function is broken. 
> 
> and that's the problem.  uncore_find_online_sibling() does all kinds of 
> wrong things including sticking active uncore structures in 
> uncore->free_when_cpu_online
> 
> Then uncore_online() comes along and frees those structures.
> 
> Then some other part of the kernel comes and re-uses the free'd data.
> 
> Then when we try to start an event, all of the fields are invalid because 
> the uncore pointer is pointing to re-used data.
> 
> I don't have a patch because I am not 100% clear on what 
> uncore_find_online_sibling() is doing in the first place.

Thanks for doing all that, I'll see if I can make sense of it.