From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932949AbcHWKXS (ORCPT ); Tue, 23 Aug 2016 06:23:18 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35655 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932824AbcHWKXR (ORCPT ); Tue, 23 Aug 2016 06:23:17 -0400 Date: Tue, 23 Aug 2016 06:23:25 -0400 From: Greg KH To: Ding Xiang Cc: arnaud.patard@rtp-net.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH resend] staging:xgifb:remove unused code Message-ID: <20160823102325.GB10101@kroah.com> References: <1471943850-22656-1-git-send-email-dingxiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471943850-22656-1-git-send-email-dingxiang@huawei.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 23, 2016 at 05:17:30PM +0800, Ding Xiang wrote: > The variable data is assigned but never used in rest code. > > Signed-off-by: Ding Xiang > --- > drivers/staging/xgifb/vb_setmode.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c > index 50c8ea4..71bb9ca 100644 > --- a/drivers/staging/xgifb/vb_setmode.c > +++ b/drivers/staging/xgifb/vb_setmode.c > @@ -727,7 +727,6 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex, > tempax |= 0x40; > > xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax); > - data = xgifb_reg_get(pVBInfo->P3d4, 0x07); But this did something with the hardware, are you sure this doesn't break anything? Lots of hardware works with the sequence of: write something read something to make sure the write worked. Did you test this? thanks, greg k-h