From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754798AbcHWSWd (ORCPT ); Tue, 23 Aug 2016 14:22:33 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35931 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752444AbcHWSWQ (ORCPT ); Tue, 23 Aug 2016 14:22:16 -0400 Date: Tue, 23 Aug 2016 13:20:57 -0500 From: Rob Herring To: Olimpiu Dejeu Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org, jg1.han@samsung.com Subject: Re: [PATCH] backlight: arcxcnn: devicetree bindings for ArticSand devices Message-ID: <20160823182057.GA8472@rob-hp-laptop> References: <1471893084-4551-1-git-send-email-olimpiu@arcticsand.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471893084-4551-1-git-send-email-olimpiu@arcticsand.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 22, 2016 at 03:11:24PM -0400, Olimpiu Dejeu wrote: > This is the device tree bindings documentation file > > Signed-off-by: Olimpiu Dejeu > > --- > .../bindings/video/backlight/arcxcnn.txt | 29 ++++++++++++++++++++++ Check your directory location. Things have moved. > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/backlight/arcxcnn.txt > > diff --git a/Documentation/devicetree/bindings/video/backlight/arcxcnn.txt b/Documentation/devicetree/bindings/video/backlight/arcxcnn.txt > new file mode 100644 > index 0000000..9cd7315 > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/backlight/arcxcnn.txt > @@ -0,0 +1,29 @@ > +arcxcnn bindings > + > +Required properties: > + - compatible: "arc,arcxcnn", "arc,arc2c0608" One per line please. Is arcxcnn a specific chip? If not drop it. No wildcards in compatible strings. > + - reg: I2C slave address (u8) > + > +Optional properties: > + - bl-name: Backlight device name (string) Use the common bindings. label? > + - init-brt: Initial value of backlight brightness (u32) low 16 bits used Use common bindings. > + - pwm-period: PWM period value. Set only PWM input mode used (u32) > + - prg-addr: Register address of ROM area to be updated (u32) low 8 bits used > + - prg-val: Register value to be updated (u32) low 8 bits used What is this for? This should be a specific property or properties to do explicit things, not a generic fill registers/rom with magic values. > + > +Example: > + > + /* ARC2C0608 */ > + backlight@30 { > + compatible = "arc,arc2c0608"; > + reg = <0x30>; > + > + init-brt = <123>; > + > + /* LED0+1 string enabled */ > + prg_06h { > + prg-addr = <0x06>; > + prg-val = <0x83>; > + }; > + > + }; > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html