From: Chris Wilson <chris@chris-wilson.co.uk>
To: Leon Romanovsky <leonro@mellanox.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Eli Cohen <eli@mellanox.com>,
Jack Morgenstein <jackm@dev.mellanox.co.il>,
Or Gerlitz <ogerlitz@mellanox.com>,
Matan Barak <matanb@mellanox.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>
Subject: Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h
Date: Tue, 23 Aug 2016 22:24:24 +0100 [thread overview]
Message-ID: <20160823212424.GA9014@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20160823211550.GQ15065@leon.nu>
On Wed, Aug 24, 2016 at 12:15:50AM +0300, Leon Romanovsky wrote:
> On Tue, Aug 23, 2016 at 09:16:26PM +0100, Chris Wilson wrote:
> > This file does not use any structs or functions defined by io-mapping.h
> > (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> > to simplify verification of changes to io-mapping.h
> >
> > The include existed since its inception in
> >
> > commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> > Author: Eli Cohen <eli@mellanox.com>
> > Date: Sun Jul 7 17:25:49 2013 +0300
> >
> > mlx5: Add driver for Mellanox Connect-IB adapters
> >
> > which looks like a copy across from the Mellanox ethernet driver.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> I assume that it passed 0-day builds.
>
> Except the commit message, which doesn't follow SubmittingPatches guide,
> it looks good.
If you mean the full commit reference rather than the short form, the
long form can be preferred if it lends significance. In this case I
wanted to highlight that it was the original commit that introduced the
include.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2016-08-23 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 20:16 Chris Wilson
2016-08-23 21:15 ` Leon Romanovsky
2016-08-23 21:24 ` Chris Wilson [this message]
2016-08-24 3:35 ` Laurence Oberman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823212424.GA9014@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=dledford@redhat.com \
--cc=eli@mellanox.com \
--cc=hal.rosenstock@gmail.com \
--cc=jackm@dev.mellanox.co.il \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®