From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755367AbcHWXuE (ORCPT ); Tue, 23 Aug 2016 19:50:04 -0400 Received: from mail-co1nam03on0139.outbound.protection.outlook.com ([104.47.40.139]:52219 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755147AbcHWXuB (ORCPT ); Tue, 23 Aug 2016 19:50:01 -0400 X-Greylist: delayed 5428 seconds by postgrey-1.27 at vger.kernel.org; Tue, 23 Aug 2016 19:50:01 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=zach.brown@ni.com; Date: Tue, 23 Aug 2016 17:14:22 -0500 From: Zach Brown To: Adrian Hunter CC: , , , , , Subject: Re: [PATCH] sdhci: Add quirk and device tree parameter to force SD test mode Message-ID: <20160823221421.GB20351@zach-desktop> References: <1471906531-28668-1-git-send-email-zach.brown@ni.com> <684dd3fb-15ac-fa84-2f1e-89f379b5149a@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <684dd3fb-15ac-fa84-2f1e-89f379b5149a@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [130.164.62.11] X-ClientProxiedBy: SN1PR15CA0011.namprd15.prod.outlook.com (10.163.200.21) To CY1PR0401MB1451.namprd04.prod.outlook.com (10.161.212.23) X-MS-Office365-Filtering-Correlation-Id: 3053617e-c253-4986-a42e-08d3cba2d895 X-Microsoft-Exchange-Diagnostics: 1;CY1PR0401MB1451;2:AllYIiE39jK6ySAlVdkmkOV2pTIOt5HVz1ovDtT+5whM5PQfL1xZAnf6fhdxYEs0W31sG1ie9hBJwaDGMuR28fpluPS8Qnh8fDSFfnGu38wxHexiUsvojKCp48kELsp4Fu5E3DNPfWDr5WgcbEKhx/sLfXgoDiBbfOzVkNwvuroA24abojtWLYvCb6BUwScQ;3:fyfcL7/5EqL68ZenXNFPCGjMihpzjXcsXqAKQ7OFYvs649ogmZljc+7tMRPUFwyNBv4eOpn4unm9bOWwBAP3+MNsjhS5v5BF5MagsV8y4muN6sET3NLU2PIqY0Ew43SZ;25:a0R7704kf3IWuzC8nC5haQ+mes06lyHHHx8sabJZcjRJmTp22Tqvc6m3LlshDpaHxOmTA+FoY+Ji0yGMOu4+a/X+GXqaKt6ExJ7cEqaH0rP6O31n/v8+Y3RwYAwsCAcygiQ7+XruPwGvZqKarTfLWdFxfGfki1rm9uHlhLAbaUyh2vVTnOUoiBd5D7yq5tPZy0NONFVIGNjLL8rMrVet0aWEy6igu2R45S0WHvjUJjvo50/7GEdc8vNNTuU1xKokEElPefNbV3I7S8n/QwsitD4b8tvRXLEUjqdtkCSljSoxNZXJzgoYID4b9d9/v06AfLd/VWW+H2cljd7BbTFpa308yzOePY1cVsd4vKxhRfPwYXCsU57nWYtxWUlMlSRmmmE3D8sX/gXbtgFFmGkUKVDHzfv6kseWPfhLJ6wyBjM= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0401MB1451; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0401MB1451;31:I1OzLEJfvToUkTA+/E0Za1zD0UB1Ny5u3eLpjndu2hXiAPXgkv7oePXMAJyksSf+xFF/nl0BUW6tYcBVAw6WBYAWHzjHoRH2Crczmrj0BBFP+ASqKAKaeSTXccwQ4apSVEmUlyrKnykId1o7b12RnyJsBrAD/5WhQLYPZX4VNCmP20JZoBENw5IGWi6GhWvIhY6CG9lWC1SrzTgI48y0HzXL9M3hq21ZTu8/sXO9dC0=;20:sEKrLYISD13zVlMwQATUzCchxo6oje1EoxiyT4P+Wgfw5ozBzAY851sjHP8ckNBGSUuEVZSjtwFQvoYdpR7/W6T4Fp75T3f1qp+i75M+PH7ntsGop3DSdVxpaqStST2uXEqM6Rz4XXpmGfFYqrwbEnK1Q+eCU6xFZynaEgWRdY/3rD727C2uJqft5Lh5Elpgj41S+h9V1nWLT/CcDb1hnri7kliJcici3/VW7T+h8fwAw8AN5jeLLJ4s0O8orBwAny6FRXWYjjnXtuuvCP88AIcnf+Tg/oPeNShSgv1ffagJ8pZNzGQdMEtB1RDvTiKEXus5tMCLZYJn6boGtGZI/eD2ZLbqdY+eDTp1sP3Z0YPexd5WkfALmGw7omdeLqg/uaj5NmJ5VvQv0eD7NoCN52PRp12qqOD6ZD6Itv6WviY8VsiIvbpXS7CmMHjWyl/sfc74vr79HtFaUG4KS++43yO7v0/uqHJyoqDyZ/9B7hnMNFGCu2CaTkQlG5iFEu2pH4ykMRJdnkqJLTWui+AWlLnVNJPHLLlze9W9oNmDrFiOcZrLLfhYuRG/viTXhXdBuiGB0cUph8rYzNCwon/qlpTI+9qjTljJPpf1tF4U9gs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592)(189271028609987)(145744241990776); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CY1PR0401MB1451;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0401MB1451; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0401MB1451;4:sD+jKHlCkS5KuwOg9XkDlnTcxNPpD45h2Di8/Xy0rw6kVrTN+aiGrCxhta6cLMgb4sSB987iNh1DwR/h0XcyeEnjhVGFEBDElWK3AMUyBy/mTksAaxCO24Xs/IHTGp/Qjy7yl6D/1Bw10dW5ZI5CHRKEvjgcsJH270ZU/RQkBLrRZ43LV81I9jSmoqpDDGxQeRvZt4iQNaluRc2ZdXXugK2mjLm+ezURTvQgFrM7ZfFfaFIrETJOovMk6alBrSSRmUATziUkKhiZWts3k2H09fcl8LU6Oq8aMYQamx7hGV1fpaDue/wip2Yi/XqaTPmB3fjn+7Mjz0vGWIP5q3wsY/tUPIs4tRuFMr1Y3gFt9QcbdQyFfAmPkZKUYONxa06CD2wMAMfWLynHo54E2MzxW1fSGrlxbc6N43TMYV8M+Dv9rtaPKvP6Zhe6fLPptUw/LowO1Q4NIRjrFn4/Lc/ELrtWZNi+ZN+Xh6dqH2n8bzmQbXw2Vm0JR68sAEmq8x1M X-Forefront-PRVS: 004395A01C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(199003)(189002)(24454002)(586003)(7846002)(47776003)(66066001)(7736002)(97756001)(105586002)(3846002)(19580405001)(6116002)(9686002)(76176999)(19580395003)(50986999)(101416001)(68736007)(54356999)(46406003)(23726003)(1076002)(4326007)(305945005)(106356001)(33716001)(4001350100001)(42186005)(2906002)(33656002)(83506001)(97736004)(110136002)(2950100001)(15975445007)(86362001)(50466002)(92566002)(8676002)(81156014)(189998001)(77096005)(81166006)(5660300001)(19300405004)(18370500001)(2690400003)(107986001)(562404015);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1451;H:zach-desktop;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR0401MB1451;23:UwHFRpyfUMDHFifpyIGKF7JmoHZwQUjdsvPgZxf?= =?us-ascii?Q?QsuZXeh+6yBh4DKZd7THXModAd7Yu/hqfpIoGg+eYg/ENfZ+RIHu3qZu8Ncw?= =?us-ascii?Q?BZi8zv2Ilx+tm+4R+kfAexge1V0Yea9f+6zk0tHrnC+2eWF71S1uxb8pEfhu?= =?us-ascii?Q?9cfmdNlynrqWyJPllDmxCMd+PZtCVGYW1pB0ztPYxZq/LAib7kj1n8GcOp0Z?= =?us-ascii?Q?BV3NFrTyUxIImlEP+ZL+NkpezYbtfm9jfRegQ62L5vtocPu9CebRfO2Cg6/C?= =?us-ascii?Q?aJVHgC8JgJZW0eSbKshsmRSMcFpeVRWh5SBQQgxEtqcgmkZL3le82RAhYAOB?= =?us-ascii?Q?97PZ4xtoYPDYZvEHXoNy/nNdDFCS4L6LDIHzVAOZwn0fPsewV96t5OzukBsE?= =?us-ascii?Q?Ryaon+uUB9qV8lU7uEWtFcxFRHIYyA+cbV4iipx5EsNq1EWVjTLdvsiKU3b4?= =?us-ascii?Q?4DH7xNl/xB90vYXnpiFHIUWnNQyEO6HarXPB+bS4Dkpmhd69lkLlC/v5TNfc?= =?us-ascii?Q?+0mYCVmwBBqx/BowbiLtVq3kmQoui7yCwyZsXBzkPUPph0/2lnRWdzvd+yge?= =?us-ascii?Q?tc3gwXoNAmtHO4F5WayuHZHbqrQX+/6Wl5PD6M2nu+Jp2t1gnaaMIXzErY+a?= =?us-ascii?Q?KPcRQqZRkv3d/FrceglTRMosFzw9H1r0QLZhWAwgBD86zzy9RToHBxWVrnbW?= =?us-ascii?Q?lsSNxPz1GJW1rn7sV1yY/SvGSxhFPEjiHq5wsEs0aHiDizHCo22Y6+BSF1pR?= =?us-ascii?Q?cGUOMLYP9tboLcK6DtjwoAuL33siOn9U/Y+zVuHzR0Y7FRG8M3+q4A2p+HSZ?= =?us-ascii?Q?NoJeV+yTN+xVWiEb041GnZ5lNisIxfCPqeyRmZOi70Z0kcNJeF8uHIXTjVbE?= =?us-ascii?Q?n0jVBMZmHi3FgFt2+5crT09QwCor8Je5IdnDwcq0hVExZxCpS49VPuyEv1Ul?= =?us-ascii?Q?RXZSLFZhddRgKMYPeIj2UG9RlpLO/YLtOg0T9ABQW10y4TcYGidomTR/zHYX?= =?us-ascii?Q?SNihLAzAkf2pdrZYYS9+tKF+8gBnZa5TgVFW58eez5yf4BbKxm4Xk3n3fJKr?= =?us-ascii?Q?zMXXF2Z9DlRuvCWfkBFzV/0A/1KMUgxvyiTm8luWzWCIFRfIAD2KJXgRBnE+?= =?us-ascii?Q?yruKVjFbp6fgtfAifmR2rcslO7j6w3s5WU8K9tV0+FAf2QEYHWa48n6b2l6E?= =?us-ascii?Q?VxcYSbhcBxNifjVWQgtMnN5aYnKHD1AI72Z0Gj3+8V0anqyeJievKEit6i7R?= =?us-ascii?Q?UE35UiFusxSaEUFFsgzeCqJzYMYE/oW+lL363An6TzEo4zwU5D9guDLSrGb1?= =?us-ascii?Q?CZQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0401MB1451;6:lvw/wxq5eJy5861U2mUPSAg7RQA884lWXaT4ExjM8nm3a15Ub9P1s1Bxg83YTzSQAQu5PLBKsE83d7DgUq2uwRwHGb2O7qU2bEXHkAl+fcs0w7NXdt1jN18E1njAZ+MUGNbl1BwzI0GMLlHnlZ+9Nd/QFVMuUIpOT/7Px39bCXiTRUJpbg9kzJvBhu7S3xzPxaShxT46V46TxwuS4Pvf82r7cIbVDrEwJWTDUe6qcDp56o1NIskanAbDhPrcAueb2sMNjII1ywGLjp1s+zH1++T3o4qzQMpS1H8/GjqtgEs=;5:PTWoVZi8Dt6MA3B02NSbQotoJR414auH3Ydg/IpS5aPVxvnmkMcgMN6UbVZwzvMJtyA3EZ5QEuY/MS3IOLZgPxu9jS548ebAcinJc08dIlFWviVAwoRmScfl1DPjTJPsdeB0/OoYDqIAVXjYF5oWNg==;24:9WNwm6N0E8wyLvI6VVFvtsemWHNmN8RX6PfKUtWyYy2Nsfe8TYOPT7siflFlsEqsUmMx6P3r2k4tYin1ks/UhKIiWTPlaj0lLs1xYW4IYNk=;7:AZcKF5UuvnXQhsviUAItxBPYN4+ltGF9uq6Bx0J0pRCtBuXrRS92jzFSWXRnY/Rp9yhfO9VkXZMgttMg34MREdbXyRaFmYIaA4Ni9ZfqVoELf0fmU8RiJ22XQS8G/7Tmrmu7tJ9P5dsUDL8I0xD/BooyN/uOr2fGrlKQS36Dw7WqvEmvyJsvabR2ZTVVTrGhmXREvagQBPbUw9f6QC+jav0/rg07jWW4gsJUqaL4R+lPgPaIu1ImDjG+OjXuAaPt SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ni.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2016 22:14:26.4264 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1451 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 23, 2016 at 09:22:29AM +0300, Adrian Hunter wrote: > On 23/08/16 01:55, Zach Brown wrote: > > From: Jaeden Amero > > > > On some devices, CD is broken so that we must force the SDHCI into test > > mode and set CD, so that it always detects an SD card as present. > > > > In order to get a device with broken CD working, we had previously > > always set the SDHCI into test mode. Unfortunately, this had the side > > effect of making all SD cards used with our Linux kernels undetectable > > and non-removable. > > > > By making this "SD test mode" setting optional via a quirk, we can avoid > > this side effect for devices other than the device with broken CD. > > Additionally, we add a device parameter to sdhci-pltfm to allow all > > SDHCI drivers to enable this quirk. > > Generally new quirks are not acceptable, but I don't see how test mode helps > very much since you still don't get any card detection events. If you > really need test mode, please explain more about how it helps (as opposed to > polling for example). > > Polling doesnt work in our case, since the issue lies with the SD controller itself. The SD controller in xilinx zynq devices requires the CDn signal to work. http://www.xilinx.com/support/answers/61064.html We have a situation where the controller requires the signal, but we can't use any of our pins to supply it. With test mode we can get the controller into a state where it works despite not having the signal.