From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Daniel Wagner <wagi@monom.org>
Cc: linux-kernel@vger.kernel.org,
Daniel Wagner <daniel.wagner@bmw-carit.de>,
Ming Lei <ming.lei@canonical.com>,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2 2/2] firmware_class: Use swait instead of completion
Date: Wed, 24 Aug 2016 01:57:50 +0200 [thread overview]
Message-ID: <20160823235750.GN3296@wotan.suse.de> (raw)
In-Reply-To: <1471942820-23767-3-git-send-email-wagi@monom.org>
On Tue, Aug 23, 2016 at 11:00:20AM +0200, Daniel Wagner wrote:
> From: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> complete_all() can only be issued once before it needs to be
> reinitialized.
What are the chances this ever happened? If it could not happen its
worth explaining why.
> To ensure we never call complete_all() twice we use
> swait and make the code here a bit more robust.
The real benefit here though is not that is it? Isn't the benefit that
we don't need all the API functionality provided by wait, we just need
something light weight.
Thanks for splitting this up, it makes it for a much easier review.
Luis
prev parent reply other threads:[~2016-08-23 23:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 9:00 [PATCH v2 0/2] firmware_class: encapsulate firmware loading status Daniel Wagner
2016-08-23 9:00 ` [PATCH v2 1/2] " Daniel Wagner
2016-08-23 23:55 ` Luis R. Rodriguez
2016-08-23 9:00 ` [PATCH v2 2/2] firmware_class: Use swait instead of completion Daniel Wagner
2016-08-23 23:57 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823235750.GN3296@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®