From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752275AbcHXFks (ORCPT ); Wed, 24 Aug 2016 01:40:48 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:32866 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032AbcHXFkr (ORCPT ); Wed, 24 Aug 2016 01:40:47 -0400 Date: Wed, 24 Aug 2016 07:40:12 +0200 From: Daniel Vetter To: Masahiro Yamada Cc: Daniel Vetter , dri-devel@lists.freedesktop.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/gma500: remove unnecessary config_enabled() guard Message-ID: <20160824054012.GU10980@phenom.ffwll.local> Mail-Followup-To: Masahiro Yamada , Daniel Vetter , dri-devel@lists.freedesktop.org, Andrew Morton , linux-kernel@vger.kernel.org References: <1471970574-23906-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471970574-23906-1-git-send-email-yamada.masahiro@socionext.com> X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 24, 2016 at 01:42:54AM +0900, Masahiro Yamada wrote: > Commit d112a8163f83 ("gma500/cdv: Add eDP support") replaced the > code inside this if-conditional with gma_backlight_set(), which > becomes a nop stub if CONFIG_BACKLIGHT_CLASS_DEVICE is disabled. > So, there is no need to guard the caller with config_enabled(). > > Note: > This is one of remaining TODOs to deprecate config_enabled() macro. > Refer to commit 97f2645f358b ("tree-wide: replace config_enabled() > with IS_ENABLED()"). > > Signed-off-by: Masahiro Yamada Applied to drm-misc, thanks. -Daniel > --- > > drivers/gpu/drm/gma500/opregion.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/opregion.c b/drivers/gpu/drm/gma500/opregion.c > index ab696ca..eab6d88 100644 > --- a/drivers/gpu/drm/gma500/opregion.c > +++ b/drivers/gpu/drm/gma500/opregion.c > @@ -163,10 +163,7 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp) > if (bclp > 255) > return ASLE_BACKLIGHT_FAILED; > > - if (config_enabled(CONFIG_BACKLIGHT_CLASS_DEVICE)) { > - int max = bd->props.max_brightness; > - gma_backlight_set(dev, bclp * max / 255); > - } > + gma_backlight_set(dev, bclp * bd->props.max_brightness / 255); > > asle->cblv = (bclp * 0x64) / 0xff | ASLE_CBLV_VALID; > > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch