From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754244AbcHXIUs (ORCPT ); Wed, 24 Aug 2016 04:20:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57724 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753810AbcHXIUo (ORCPT ); Wed, 24 Aug 2016 04:20:44 -0400 Date: Wed, 24 Aug 2016 16:20:31 +0800 From: Dave Young To: Yinghai Lu Cc: Baoquan He , Xunlei Pang , "kexec@lists.infradead.org" , Linux Kernel Mailing List , "Eric W. Biederman" , Andrew Morton , Vivek Goyal Subject: Re: [PATCH v2 1/2] kexec: Introduce "/sys/kernel/kexec_crash_low_size" Message-ID: <20160824082031.GA13889@dhcp-128-65.nay.redhat.com> References: <1471398657-20237-1-git-send-email-xlpang@redhat.com> <20160817082034.GA11837@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2 (2016-07-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 24 Aug 2016 08:20:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/23/16 at 06:11pm, Yinghai Lu wrote: > On Wed, Aug 17, 2016 at 1:20 AM, Dave Young wrote: > > On 08/17/16 at 09:50am, Xunlei Pang wrote: > >> "/sys/kernel/kexec_crash_size" only handles crashk_res, it > >> is fine in most cases, but sometimes we have crashk_low_res. > >> For example, when "crashkernel=size[KMG],high" combined with > >> "crashkernel=size[KMG],low" is used for 64-bit x86. > >> > >> Like crashk_res, we introduce the corresponding sysfs file > >> "/sys/kernel/kexec_crash_low_size" for crashk_low_res. > >> > >> So, the exact total reserved memory is the sum of the two. > >> > >> crashk_low_res can also be shrunk via this new interface, > >> and users should be aware of what they are doing. > ... > >> @@ -218,6 +238,7 @@ static struct attribute * kernel_attrs[] = { > >> #ifdef CONFIG_KEXEC_CORE > >> &kexec_loaded_attr.attr, > >> &kexec_crash_loaded_attr.attr, > >> + &kexec_crash_low_size_attr.attr, > >> &kexec_crash_size_attr.attr, > >> &vmcoreinfo_attr.attr, > >> #endif > > would be better if you can use attribute_group .is_visible to control showing of > crash_low_size only when the crash_base is above 4G. I have same feeling that it looks odd to show low in sysfs in case no crashkernel=,high being used. Even if crashkernel=,high is used only in x86 the resource crashk_low is in common code. What do you think to move it to x86? Thanks Dave > > Thanks > > Yinghai > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec