From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756043AbcHXS2F (ORCPT ); Wed, 24 Aug 2016 14:28:05 -0400 Received: from caffeine.csclub.uwaterloo.ca ([129.97.134.17]:40909 "EHLO caffeine.csclub.uwaterloo.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755071AbcHXS2B (ORCPT ); Wed, 24 Aug 2016 14:28:01 -0400 Date: Wed, 24 Aug 2016 14:27:58 -0400 To: Thomas Petazzoni Cc: Ralph Sennhauser , "linux-kernel@vger.kernel.org" , Gregory CLEMENT Subject: Re: [Regression?] Commit cb4f71c429 deliberately changes order of network interfaces Message-ID: <20160824182758.GF14311@csclub.uwaterloo.ca> References: <20160821151158.78da01e6@gmail.com> <20160824165011.6c811913@free-electrons.com> <20160824191004.3b4ff2cb@gmail.com> <20160824180727.GE14311@csclub.uwaterloo.ca> <20160824201444.487022de@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160824201444.487022de@free-electrons.com> User-Agent: Mutt/1.5.23 (2014-03-12) From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 24, 2016 at 08:14:44PM +0200, Thomas Petazzoni wrote: > Depends on the network driver I believe. But with an e1000e NIC plugged > in a PCIe slot, it indeed gets assigned as eth0, and the internal > mvneta devices get eth1, eth2, etc. Which of course means the change does not actually ensure the port ordering matches the marvell documentation or u-boot. It only handles the relative order of the ports. For now. So since it doesn't actually work, maybe reverting it so it no longer violates the dtb ordeting rule makes sense. Doesn't mean openwrt/lede/etc don't have to deal with the ordering in the future if async probing takes off. -- Len Sorensen