From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758784AbcHYHqd (ORCPT ); Thu, 25 Aug 2016 03:46:33 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:35793 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758043AbcHYHpa (ORCPT ); Thu, 25 Aug 2016 03:45:30 -0400 Date: Thu, 25 Aug 2016 09:57:00 +0300 From: Mikko Rapeli To: Bart Van Assche Cc: "dm-devel@redhat.com" , Alasdair Kergon , "linux-kernel@vger.kernel.org" , Mike Snitzer Subject: Re: [dm-devel] [PATCH v05 04/72] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h Message-ID: <20160825065700.GX5399@lakka.kapsi.fi> References: <1471890809-4383-1-git-send-email-mikko.rapeli@iki.fi> <1471890809-4383-5-git-send-email-mikko.rapeli@iki.fi> <20160823204232.GP5399@lakka.kapsi.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2001:1bc8:1004::1 X-SA-Exim-Mail-From: mikko.rapeli@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2016 at 04:24:11AM +0000, Bart Van Assche wrote: > On 08/23/16 13:42, Mikko Rapeli wrote: > > On Tue, Aug 23, 2016 at 02:28:19PM +0000, Bart Van Assche wrote: > >> On 08/23/16 06:57, Bart Van Assche wrote: > >>> On 08/22/16 11:32, Mikko Rapeli wrote: > >>>> - * uint32_t (*get_region_size)(struct dm_dirty_log *log); > >>>> + * __u32 (*get_region_size)(struct dm_dirty_log *log); > >>> > >>> uint32_t is a type that is defined by ANSI C but __u32 not. So this > >>> change looks wrong to me. Would it have been sufficient to add "#include > >>> " and keep the uint32_t etc. type names? > >> > >> Answering my own question: adding "#include " wouldn't be > >> sufficient. How about adding the following code that also occurs in a > >> few other uapi header files? > >> > >> #ifndef __KERNEL__ > >> #include > >> #endif > >> #include > > > > I have tried that before but I was instructed to use the linux/types.h > > versions. For example https://lkml.org/lkml/2015/6/1/160 > > > > But lately drm and fuse and some others have questioned this approach and > > would like to use/continue using C99 stdint.h types. > > Hello Mikko, > > Thanks for the feedback. I have a minor comment though about your patch: > are you aware that you have changed uint64_t into __u64 in source code > comments but that int64_t has not been changed into __s64? Thanks, that's a bug. I'll update the patch. I guess I was reading compiler error list and string replacing only those. -Mikko