From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934267AbcHYNtT (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 Aug 2016 09:49:19 -0400
Received: from merlin.infradead.org ([205.233.59.134]:45164 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934250AbcHYNtR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 Aug 2016 09:49:17 -0400
Date: Thu, 25 Aug 2016 15:01:39 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Hari Bathini <hbathini@linux.vnet.ibm.com>
Cc: ast@fb.com, lkml <linux-kernel@vger.kernel.org>, acme@kernel.org,
        alexander.shishkin@linux.intel.com, mingo@redhat.com, sargun@sargun.me,
        Aravinda Prasad <aravinda@linux.vnet.ibm.com>,
        "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
        Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
        daniel@iogearbox.net
Subject: Re: [PATCH 1/2] perf: add container identifier entry in perf sample
 data
Message-ID: <20160825130139.GF10138@twins.programming.kicks-ass.net>
References: <147212627442.20120.6106492652250934757.stgit@hbathini.in.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <147212627442.20120.6106492652250934757.stgit@hbathini.in.ibm.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 25, 2016 at 05:27:54PM +0530, Hari Bathini wrote:

> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> index c66a485..fb4f902 100644
> --- a/include/uapi/linux/perf_event.h
> +++ b/include/uapi/linux/perf_event.h
> @@ -139,8 +139,9 @@ enum perf_event_sample_format {
>  	PERF_SAMPLE_IDENTIFIER			= 1U << 16,
>  	PERF_SAMPLE_TRANSACTION			= 1U << 17,
>  	PERF_SAMPLE_REGS_INTR			= 1U << 18,
> +	PERF_SAMPLE_CID				= 1U << 19,
>  
> -	PERF_SAMPLE_MAX = 1U << 19,		/* non-ABI */
> +	PERF_SAMPLE_MAX = 1U << 20,		/* non-ABI */
>  };

This forgets to update the comment that goes with PERF_RECORD_SAMPLE.
This patch would also need an update to the manpage:

  http://git.kernel.org/cgit/docs/man-pages/man-pages.git/tree/man2/perf_event_open.2

  http://www.man7.org/linux/man-pages/man2/perf_event_open.2.html

> +	if (sample_type & PERF_SAMPLE_CID) {
> +		int size = sizeof(u64);
> +
> +		/*
> +		 * Container identifier for a given task.
> +		 * Using cgroup namespace inode number for this.
> +		 */
> +		data->cid_entry.cid = current->nsproxy->cgroup_ns->ns.inum;
> +		data->cid_entry.reserved = 0;
> +		header->size += size;
> +	}
>  }

Does this compile with CONFIG_CGROUP=n ?