From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759482AbcHYPLn (ORCPT ); Thu, 25 Aug 2016 11:11:43 -0400 Received: from mx2.suse.de ([195.135.220.15]:38668 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934176AbcHYPLl (ORCPT ); Thu, 25 Aug 2016 11:11:41 -0400 Date: Thu, 25 Aug 2016 17:11:38 +0200 From: Petr Mladek To: Josh Poimboeuf Cc: Jessica Yu , Jiri Kosina , Miroslav Benes , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Chunyu Hu , Rusty Russell Subject: Re: [PATCH v2] livepatch/module: make TAINT_LIVEPATCH module-specific Message-ID: <20160825151138.GK4866@pathway.suse.cz> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2016-08-25 10:04:45, Josh Poimboeuf wrote: > There's no reliable way to determine which module tainted the kernel > with TAINT_LIVEPATCH. For example, /sys/module//taint > doesn't report it. Neither does the "mod -t" command in the crash tool. > > Make it crystal clear who the guilty party is by associating > TAINT_LIVEPATCH with any module which sets the "livepatch" modinfo > attribute. The flag will still get set in the kernel like before, but > now it also sets the same flag in mod->taint. > > Note that now the taint flag gets set when the module is loaded rather > than when it's enabled. > > I also renamed find_livepatch_modinfo() to check_modinfo_livepatch() to > better reflect its purpose: it's basically a livepatch-specific > sub-function of check_modinfo(). > > Reported-by: Chunyu Hu > Signed-off-by: Josh Poimboeuf Everything looks fine now. Reviewed-by: Petr Mladek Best Regards, Petr