From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759585AbcHYQAT (ORCPT ); Thu, 25 Aug 2016 12:00:19 -0400 Received: from mail-db5eur01on0091.outbound.protection.outlook.com ([104.47.2.91]:57264 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752974AbcHYQAR (ORCPT ); Thu, 25 Aug 2016 12:00:17 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dsafonov@virtuozzo.com; From: Dmitry Safonov To: , CC: , , , , <0x7f454c46@gmail.com>, , , , Dmitry Safonov Subject: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe Date: Thu, 25 Aug 2016 18:21:09 +0300 Message-ID: <20160825152110.25663-3-dsafonov@virtuozzo.com> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160825152110.25663-1-dsafonov@virtuozzo.com> References: <20160825152110.25663-1-dsafonov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: VI1PR06CA0038.eurprd06.prod.outlook.com (10.162.116.176) To AM5PR0801MB1729.eurprd08.prod.outlook.com (10.169.247.7) X-MS-Office365-Filtering-Correlation-Id: 60fcdae4-6a51-47eb-ee0d-08d3ccfbc411 X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1729;2:4SlzC27KH/kjIGHub2pgB6xl8DhauBZ1PbIUKJLPSHNAamifSXeArstr/AaKw5U8w/pCFMftmYgS3w7/V34JSoUuom+H+uO/3SgIIfwOcdbZ/cCfGXQgbJCTsYpuqk/FSbIgoUxvLFSbAT8gN59wxa4/cn8mrBr4n399HHefJleOB9a5hFHs9W+u8NdWaVZ5;3:pJsy1+D2P4+i6O6r/wOz36DOLSLwoWlpDbR5JlB5n6uXTiUxkiw2+NULnn6tqiTJ/GxB3ayJcRkhWpQrcEk5Lopf3YlcDIiAxlNgn4k+VaS1bYPuQoItD2KjAqaG/SD2;25:dUneCbHISr7Rt7h/s5O8F920KFjL69L9D2D3ANNRwOtPrZxYWB47QryPpaeJ7dKSGrFsZk/ojmwDol8+8atcLd41JpZvtDtx6QPb0xciE8ohlXCjvoTxgApwnKSKIBDVmZmSHmoxKJc0A9EZpbJ/KrRdJnmt+MmetkE5lLKiCYp1mVVYwNmy78R4ja5J9Mvlr14mm42Sd/Tc3zBW4ECPNmrpVYQB+2QBV6ONzVqyOi31xvr2lTazo3ahzh37NA6ERD16YHJ6IKdvV7iOWdCs5cy0HLRERs/QSgw29Et7m3yIFPg9TJOMore405nrtgqQE8ts+hs1uGTU8xNoD2a3U+uTZyS115vqY4tNd8zoreGMOpVWAtajBMbiK6dLvIzV/MYEoMEgTlOLTf59xl8vY0QXsrarzvOiebS8S7sEv6A= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0801MB1729; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1729;31:xQlbvOjav3Sn+r//Qiz/Tx1ueyawc1jwQ0jVpFJ6vt1qP/1+VCQXcGSSfuCSHiZBZhB+CSTDk4yRU1jqYvD+fzIrbWd03evJMPhO0HPzzmXy/1FKTFs7ePlPZw3qswx0sVGG1t0mMp35P2DeCy9d0RoOGkfNgx9G3MpuY3neYjVekJPzp+LKmDt87w3QljfILucLsgqauassxle538o0KqBeCyFXBmpT/+fjD4RII5o=;4:qDbL+6mxOUwzFvXmGF6qnSmrz2sJW6GPgjPeMObWfE+VvK2w+Dk3pSiG1+fo3PL+e/kaUwopzNt2/WCEu3AVQCUfydgRdQHVVVbZiD6AOHFXVgVq81/ouGi5NpXIB7lyHNhcC94drsKMbhrh35VN9daP1Y1fMRHS7sexjPNeoPOr8qOfx4RwfK0WM1bRa49uv6e4W+ZgJYwqFiG2Sxa74mgAf3eXE493NkyQ82gDh/rdeIKEpS7N3/yg07TYZfOy0ye/sXJsmPGk6jHIJDzawhMMbQywjos8nkQ6Ojx0tHDBOtsx7Zlgt6ZEBoj1oNoaRaVwYE/pxnIAMt7nFEOCfCwgM5AAZ5fXWbFNdySRXpHiD4ohXF45icik89lnT5IzUyHA7bVY3xpMddkXGxpUQ6dsAE3fXbfOZvJQuxfLB/g= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6043046)(6042046);SRVR:AM5PR0801MB1729;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0801MB1729; X-Forefront-PRVS: 0045236D47 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(189002)(199003)(7846002)(81166006)(4326007)(189998001)(105586002)(50466002)(48376002)(33646002)(36756003)(19580405001)(8676002)(6116002)(97736004)(81156014)(2950100001)(2906002)(7416002)(1076002)(77096005)(50226002)(3846002)(19580395003)(5660300001)(305945005)(68736007)(101416001)(76176999)(50986999)(86362001)(4001430100002)(7736002)(586003)(42186005)(53416004)(69596002)(66066001)(5001770100001)(47776003)(107886002)(229853001)(92566002)(5003940100001)(106356001);DIR:OUT;SFP:1102;SCL:1;SRVR:AM5PR0801MB1729;H:dsafonov.sw.ru;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM5PR0801MB1729;23:sKlcwWzl75SE1FPTqxC5686Cr6lukXTMOm3jpf1?= =?us-ascii?Q?7Jcz1KpYV10zG/3SMMwna1zzBW7sXeCDnAPYFHzq3Bozeh9jKEZTESeVBU4N?= =?us-ascii?Q?2dBpfRcRXRL4Ku701fAtWm06aP3UhciA3ds0k3lDRAyF2QSvcCPe/zYM2/P2?= =?us-ascii?Q?aKBNHHELHcCcqjyKQxZAxbhFyosDgqR7MKROMhirdsOulLOjDRBbOFKGkucq?= =?us-ascii?Q?IVQBAA6xz77q79uVoSOJSBPMuKUdNDM8GSpwM3Gynwn3MVFuo8QwCZATlwTV?= =?us-ascii?Q?q6tkip0lmIn1nLo/GYeSp5+JkHZKJ8/x2L6Pu8wbqeUhxsxcKatOtEohIa7L?= =?us-ascii?Q?LRQa6ZTXUcl26Kx2vcaCupq4/b6Z6D95ZKP+CdYgq7dNsEYd7L7/ciLDhcf1?= =?us-ascii?Q?4KpntuK1eMvHQ7cIOAvUjvoDtsW4wulSYmFwgdwl2CB2AV3xAcCvpFDpmaM8?= =?us-ascii?Q?gSeif55qJDFpWXRfTlN/z1XmfhOsgEoMHtMt5Q9UdyW+SZCEjEKVnQ7TQ+dq?= =?us-ascii?Q?xRJKPR+JlLCZgNwcc7OowfGB5NRrIadOsGYuyb1NBEIbu9z/txpoMdbf5I21?= =?us-ascii?Q?feWdI/2U6aJyzXR1lDMx6CkCYImUOPDR8dFEq+UNxN8xE4ZL2U0YdmiJ2i5a?= =?us-ascii?Q?Bk4lTu/xsp1i/VerAn9fMZqrFQo5+J4VPn+fB4QCHWa4wKzvs5qu40xKwUXI?= =?us-ascii?Q?N7XHA6QlFT/hH1NQwRXXG+jvbD3ZyJQRiuAmFXQ9hMNfK7YgoR1htu7+VOlb?= =?us-ascii?Q?Wnj35kYW6PVBvRzw3qjdFCcgpm+jFsVeB0CgIPLphRL7YXamVq7qe3vGV8QZ?= =?us-ascii?Q?f/AtK5cQzArLK2UJ16jvEkk8K1JzA+uR2fUwQ99UwFr6+NdJqILEidKZHQ/y?= =?us-ascii?Q?DczugfBXZYJhGMtHpVTtyCdEiGsoVz6+qILAGQpEz4Adn/xkCI8qA37mBRiF?= =?us-ascii?Q?259bEd0HPL7lJPRqYbknAhGZ/1AkVihBRamIJVwNMWtRDxDDvSvIrf76JsJS?= =?us-ascii?Q?xx6TJjEOq3UHQkOYtDQ38VvViskOmZ17OZO2IXA4jc7gBEcefagyULmAKLN7?= =?us-ascii?Q?5R5wOaPn/tsAGYvrlBodKIxzMAdfbHmnIs/S9KFTWknfvpzfpGYgUNIaV04V?= =?us-ascii?Q?0zqe1sAyYRKaCKfxyUuXIsmFhokKhCUPjnxaJzH8Cm9YYWZdKtTsKK6j3Ieo?= =?us-ascii?Q?Oh2WtC4uxNiji5lS149DET8O9s+zHuNKpPssNlkpUhEy1mDLvW91qavo6ew?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1729;6:3qKIjNVZ7FQmdnh8lOhGkNeBYwdxTFhI86Q7jSQupa8VPo4m/v5M9jNT29ttQnUR1x8+5iO4AY5QlIH48h1Xk+F3bYCUNgulk6Py485Ul3NIqNBWyd4b5CsnsbG3fIELid7aavi6ba0vvu9ezyxeX7LjTvO4rb/aicfnC0Jb/fcA0PWt7sHfeKtLlCrypxx8twVRRRpLKxoirBQHnWsoFi/DPJNCnzq6ExTdS+I2QCnC9gpDeCwYEIllU/aaZFRx+2f2w4Pme1XRVDlH2tj2A9iUpZHH0Ck02TMMC5zvBXDqPeskbETACLvzaWUbRYpv;5:GPdHPG9pEaqXwR6gGbqsUEHtdA6O7SdnTIEijwFl2Skz2fOtQXLvK30842Y40VoGTRe7tWSv93gHJc3PVc/+Pjw3Fm+dd1RoXROlQGRVV5vFM57dLlwG4CXeVUXkAjvFOC4ryTL23GEhjUDKZcvnrw==;24:EKD49yB5Ed8E80uBVz7bBdW9lzStWkpol53jNiIGctcIQZfFVzH45YjsAJBsCnjGYnyXMJoZv4Cyzc+Vn4J1NTXdURmRcZ2t4Xcmu1Q19RM=;7:AkDEV2jvINEtaJ1fDeQle8qkKkMy3L/NbynI5m7fhTVDJx3J7eL1a1S7+lX/D4Hi4pZeFvz5wsdZmg+8qLTYz1K+gHGHipxwJbKhE4dYhhiPO5z5OTD4qyeFaXobrugZmGJbL7EWIQXeSakygpdL2j75s3xofHmF4gls7IoZeNjb+TMsx1UBXdINMcb5dckWsgb/dRA4ldQA0V1oeqt7DXy2nBShJsuXzXGn6hHUKOPGyWCzRoqWn+ATL0+li5s6 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1729;20:WxLeE0nmOO39jpjJbE7QBSrRVaijci42hzsz7szecR3xTES2lYg2+Qmvs40Ja2n0eM9cj9SiTLli3duYw4y4UHZe81SOu0/1aFmle8kIA8FSk67JIn5tZiavj0+ewFEi51A0uJm1IKe4y+E/faFOiiYS4P/0upmAVKy0/TJrB0M= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2016 15:23:27.6659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1729 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's useless. Before: [tracing]# echo 'p:test /a:0x0' >> uprobe_events [tracing]# echo 'p:test a:0x0' >> uprobe_events -bash: echo: write error: No such file or directory [tracing]# echo 'p:test 1:0x0' >> uprobe_events -bash: echo: write error: Invalid argument After: [tracing]# echo 'p:test 1:0x0' >> uprobe_events -bash: echo: write error: No such file or directory Signed-off-by: Dmitry Safonov --- kernel/trace/trace_uprobe.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index c53485441c88..a74f2d9ff379 100644 --- a/kernel/trace/trace_uprobe.c +++ b/kernel/trace/trace_uprobe.c @@ -427,10 +427,6 @@ static int create_trace_uprobe(int argc, char **argv) pr_info("Probe point is not specified.\n"); return -EINVAL; } - if (isdigit(argv[1][0])) { - pr_info("probe point must be have a filename.\n"); - return -EINVAL; - } arg = strchr(argv[1], ':'); if (!arg) { ret = -EINVAL; -- 2.9.0