From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756501AbcHYQTo (ORCPT ); Thu, 25 Aug 2016 12:19:44 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:46539 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393AbcHYQTn (ORCPT ); Thu, 25 Aug 2016 12:19:43 -0400 X-Sasl-enc: YuukJYJOO3iboBWPlvB46G7JNqycZqYI/zKD1s9E+XF9 1472141981 Date: Thu, 25 Aug 2016 19:18:13 +0300 From: Andrey Utkin To: Anson Jacob Cc: gregkh@linuxfoundation.org, abbotti@mev.co.uk, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] staging: comedi: ni_at_a2150.c: Fix checkpatch warning Message-ID: <20160825161813.vui6lh4np3kboexu@acer> References: <20160825154708.a55hsffnfdz2zqac@acer> <20160825160923.GA6998@X250> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160825160923.GA6998@X250> User-Agent: Mutt/1.6.2 (2016-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2016 at 12:09:23PM -0400, Anson Jacob wrote: > On Thu, Aug 25, 2016 at 06:47:08PM +0300, Andrey Utkin wrote: > > > > > +#define CHANNEL_BITS(x) ((x) & 0x7) > > > +#define CHANNEL_MASK 0x7 > > > > No uniform alignment. Please get everything in a row. > > If it's hard or this part of driver is expected to have a lot of changes > > in near future, then I'd remove any whitespace over single space between > > name and value. > > > > I didn't get your point in this case. Could you explain it. Reviewing actual source code with the patch applied, it looks well. But if you look at the patch email itself, or in "git show , the alignment is broken. This is an illustration why using tab characters in the middle of lines is bad idea. However this is what I see in lots of kernel code. So feel free to ignore this point.