From: Masami Hiramatsu <mhiramat@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [RFC PATCH 2/4] perf-probe: Add offline output directory option
Date: Thu, 25 Aug 2016 19:48:16 +0900 [thread overview]
Message-ID: <20160825194816.471b954460d3a897ed9c0cae@kernel.org> (raw)
In-Reply-To: <20160824125845.GB10063@kernel.org>
On Wed, 24 Aug 2016 09:58:45 -0300
Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> Also please fix the OPT_STRING string, it should start with a capital
> letter:
>
> --max-probes <n> Set how many probe points can be found for a probe.
> --no-inlines Don't search inlined functions
> --outdir <directory>
> path to offline output directory
> --range Show variables location range in scope (with --vars only)
>
>
> See how it stands out? All the others start with a capital letter.
BTW, actually in most case, perf shows option explanations start without a captal letter,
./perf lock
Usage: perf lock [<options>] {record|report|script|info}
-D, --dump-raw-trace dump raw trace in ASCII
-i, --input <file> input file name
-v, --verbose be more verbose (show symbol address, etc)
etc. Some commands (including probe) mixing it...
Thanks,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2016-08-25 10:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 5:57 [RFC PATCH 0/4] perf probe: Introduce remote cross-arch probes Masami Hiramatsu
2016-08-24 5:57 ` [RFC PATCH 1/4] perf-probe: Remove unused tracing_dir variable Masami Hiramatsu
2016-09-05 13:19 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
2016-08-24 5:58 ` [RFC PATCH 2/4] perf-probe: Add offline output directory option Masami Hiramatsu
2016-08-24 12:58 ` Arnaldo Carvalho de Melo
2016-08-25 6:37 ` Masami Hiramatsu
2016-08-25 10:48 ` Masami Hiramatsu [this message]
2016-08-25 14:40 ` Arnaldo Carvalho de Melo
2016-08-24 5:58 ` [RFC PATCH 3/4] perf-probe: Ignore vmlinux buildid if offline kernel is given Masami Hiramatsu
2016-08-24 5:58 ` [RFC PATCH 4/4] perf-probe: Support probing on offline cross-arch binary Masami Hiramatsu
2016-08-24 13:03 ` Arnaldo Carvalho de Melo
2016-08-25 6:57 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825194816.471b954460d3a897ed9c0cae@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome