From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758851AbcHYMdV (ORCPT ); Thu, 25 Aug 2016 08:33:21 -0400 Received: from mail.kernel.org ([198.145.29.136]:60806 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754281AbcHYMdT (ORCPT ); Thu, 25 Aug 2016 08:33:19 -0400 Date: Thu, 25 Aug 2016 21:32:10 +0900 From: Masami Hiramatsu To: Ravi Bangoria Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, mhiramat@kernel.org, wangnan0@huawei.com, hemant@linux.vnet.ibm.com, naveen.n.rao@linux.vnet.ibm.com Subject: Re: [PATCH 1/2] perf probe: Helper function to check if probe with variable Message-Id: <20160825213210.5aa46e09c12599a5a0b94b42@kernel.org> In-Reply-To: <1470214725-5023-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> References: <1470214725-5023-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 Aug 2016 14:28:44 +0530 Ravi Bangoria wrote: > Introduce helper function instead of inline code and replace hardcoded > strings "$vars" and "$params" with their corresponding macros. > > perf_probe_with_var is not declared as static since it will be called > from different file in subsequent patch. > Looks good to me :) > Signed-off-by: Ravi Bangoria Acked-by: Masami Hiramatsu Thanks! > --- > tools/perf/util/probe-event.c | 22 +++++++++++++++------- > tools/perf/util/probe-event.h | 2 ++ > 2 files changed, 17 insertions(+), 7 deletions(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 953dc1a..bc9317e 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -1592,19 +1592,27 @@ out: > return ret; > } > > +/* Returns true if *any* ARG is either C variable, $params or $vars. */ > +bool perf_probe_with_var(struct perf_probe_event *pev) > +{ > + int i = 0; > + > + for (i = 0; i < pev->nargs; i++) > + if (is_c_varname(pev->args[i].var) || > + !strcmp(pev->args[i].var, PROBE_ARG_PARAMS) || > + !strcmp(pev->args[i].var, PROBE_ARG_VARS)) > + return true; > + return false; > +} > + > /* Return true if this perf_probe_event requires debuginfo */ > bool perf_probe_event_need_dwarf(struct perf_probe_event *pev) > { > - int i; > - > if (pev->point.file || pev->point.line || pev->point.lazy_line) > return true; > > - for (i = 0; i < pev->nargs; i++) > - if (is_c_varname(pev->args[i].var) || > - !strcmp(pev->args[i].var, "$params") || > - !strcmp(pev->args[i].var, "$vars")) > - return true; > + if (perf_probe_with_var(pev)) > + return true; > > return false; > } > diff --git a/tools/perf/util/probe-event.h b/tools/perf/util/probe-event.h > index e18ea9f..4d1139b 100644 > --- a/tools/perf/util/probe-event.h > +++ b/tools/perf/util/probe-event.h > @@ -128,6 +128,8 @@ char *synthesize_perf_probe_point(struct perf_probe_point *pp); > int perf_probe_event__copy(struct perf_probe_event *dst, > struct perf_probe_event *src); > > +bool perf_probe_with_var(struct perf_probe_event *pev); > + > /* Check the perf_probe_event needs debuginfo */ > bool perf_probe_event_need_dwarf(struct perf_probe_event *pev); > > -- > 2.5.5 > -- Masami Hiramatsu