From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753507AbcHZP26 (ORCPT ); Fri, 26 Aug 2016 11:28:58 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:51164 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbcHZP2k (ORCPT ); Fri, 26 Aug 2016 11:28:40 -0400 From: Arnd Bergmann To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Arnd Bergmann , Linus Walleij , linux-fbdev@vger.kernel.org, Russell King , Tomi Valkeinen Subject: [PATCH 2/5] video: ARM CLCD: fix endpoint lookup logic Date: Fri, 26 Aug 2016 17:25:43 +0200 Message-Id: <20160826152546.604384-3-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160826152546.604384-1-arnd@arndb.de> References: <20160826152546.604384-1-arnd@arndb.de> X-Provags-ID: V03:K0:kpmxnr+U1b1J0EpZw0f63cBnxgbXb8cDykyo/Z7i7EC7d1CVaQP vfgNx3waXBckIEut6e44Jq4ykzFlORkn2PIzECj4BVRioExsvkoNJa3BFJSazTyPiTbYWCN X9K3GGtGRBK++vuAPth+HrVEIpQWskE3EgjgX0PZd2vIB/ViDD/XqUxUs2NroJKo/SgiN05 SGE794cgXYqnIAab1ko/A== X-UI-Out-Filterresults: notjunk:1;V01:K0:8BfoEhLG2r4=:ivtX9dccO45tsCeDgdMJxM T2ApZGM4UHnaZqPZwi7rnfkNwO7KWJW0wVKDnHgOttqd4LgAjTb43MC4wzZHrsj5JN+es3+ej 17o/78pxRErcKN+pKeI/pI4wghSWaLQSfHPHhcu5vdwvzuyTtHxDwx3ag4cNllVUCf6P0fuSH utMNtdKEtXI7MX7PtO8+uv8Cj33Ro9SKdeT9MkY4CfRbFe22LES6FVE7MW1iL7h46QPjvKuxV /wFjqmz1EdyEueM8lEVv2DJikqpy4osmQrw68TSt2r3mtkyFfS9+18EmDuml3C3BRXKQqYi49 pADkrPqZyUqFCXM7BSG6IRu9iUXje6UVS/Zct/7IIGq77PywZ8g5fSnHegubj4iDjNU/NzibN GmxwfnDZiGAaBusf2AM+GKZ7WGewHoElq3cOHO1pMuKIV7BZ+LBJpc70EDPJyfGWucqCGzQiS nicButPUIIS3mzqgoMc+JvOTqUiGTzscGgzrXejogQRC6hy00MAflmSsTh6yxoIEt6iaabSEh x2izUxHiwtiHbftA13XFSIedSqO+MKVhJASNIbgx8x91aXBeYzJXe0QxRWen2L7wnQDJSNG5X 6oTrjJA3tXjXJ7N57UP2zOcK9CffWaIu3Bf5qg4twNhHQTAoDXHcrV1OnRS/v7tl8nfdU5UI5 wiMOkWWNUhleSHHNwuqGvhnG4CIKyEEqHBJEiltLbrfT9NDvqGjmFgvbn8rWIl/fXPFQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The addition of the Nomadik support in this driver introduced a bug in clcdfb_of_init_display(), which now calls init_panel with an uninitialized 'endpoint' pointer, as "gcc -Wmaybe-uninitialized" warns: drivers/video/fbdev/amba-clcd.c: In function 'clcdfb_of_init_display': drivers/video/fbdev/amba-clcd.c:785:5: error: 'endpoint' may be used uninitialized in this function [-Werror=maybe-uninitialized] This reverts the broken part of the function to what it was before the patch, which is the best guess I have to what it should be. I assume this was left over from an attempted rework of the code that was partially backed out. Signed-off-by: Arnd Bergmann Fixes: 046ad6cdeb3f ("video: ARM CLCD: support Nomadik variant") Cc: Linus Walleij --- Cc: linux-fbdev@vger.kernel.org Cc: Russell King Cc: Tomi Valkeinen drivers/video/fbdev/amba-clcd.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c index c342ff370108..ec2671d98abc 100644 --- a/drivers/video/fbdev/amba-clcd.c +++ b/drivers/video/fbdev/amba-clcd.c @@ -782,12 +782,9 @@ static int clcdfb_of_init_display(struct clcd_fb *fb) /* * Fetch the panel endpoint. */ - if (!endpoint) { - endpoint = of_graph_get_next_endpoint(fb->dev->dev.of_node, - NULL); - if (!endpoint) - return -ENODEV; - } + endpoint = of_graph_get_next_endpoint(fb->dev->dev.of_node, NULL); + if (!endpoint) + return -ENODEV; if (fb->vendor->init_panel) { err = fb->vendor->init_panel(fb, endpoint); -- 2.9.0