From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753837AbcHZPaZ (ORCPT ); Fri, 26 Aug 2016 11:30:25 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:50818 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbcHZPaX (ORCPT ); Fri, 26 Aug 2016 11:30:23 -0400 From: Arnd Bergmann To: Jonathan Cameron Cc: Arnd Bergmann , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Srinivas Pandruvada , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio: hid-sensors: avoid unused function warning Date: Fri, 26 Aug 2016 17:29:35 +0200 Message-Id: <20160826152956.666025-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:STYgNATyh0bZmAn0uIRsdWMmZkuAd9LH/lc+4BCZARCCUstcBAw 0QApKs69AsfKxAIc4br4iM6U2jDe85pnltsUHf4qaXxr8m+ezyPyQfmhX28V9a3k0VF5mTY RrGSn7jKU5SDrFeN20EAmbhB8DcnKuMGjdoeRRvZKoC+zc2Pnzmy6fLH1jCilFRi3FFRQLk h8j2hJBHWPqnJYOBw0NLQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:eaNjTr4zYy4=:aQaTvlDUsqOAEBPFsJtpwM 1/UADDh9iR0o61RnrCeQ88279IX/nzHV5t6eemlEJ0MO4SqN7/EZMQQldBQE2fDrWETPxzWRT szWZ3tKBKUWhllNbWWX37K3vD4u8qvsOVbLouTtRw35qBMpIZbhdBVo0U8bJsGtAj+fT7HNG2 EioYlwRHbZSUorNx0oiPho8xNtjJWP/GZC53a8eMz+6RJEiwinYRFPDIKBaiOs0vGRq2U5/ol 4RGjSLOYcXC0u654oDTpGmsRva7Is0nj0pzuvMMeAX7HhtdUqUYonapp02mhw+SbRl5gthCoG 0W466ESfm1hdSvZ2aXPB6CJDDWrMCZOAaSHz/s08KMAn7rpKE8eybMVEtAOPqyYOuIG45XE7M UrKKNGGs0/IkLpIDJyNJYH89a4c9E9ZIFFsSFLe4ZxMACaN3v/tY2Kq1e0b+VKR4mZzeytSib QrlDG7XRzbBW/DTRcBVfjBn4+bUyZFG3fpEewphLNQuGFva0vwKVF3imos2Tv4HVoNUjdx3Ho 67C17M/SFg8Cig4vTssg12bZhVyzToHbZIBPapB+1CR8lIevVgQDIYM4uKagzJ7wSoHjJsHmf vBzr9Lt0+8m7Gd+2gz66CoOlzZ9jKt/BzZ5oAaCztsw1DZi9cD5qvDTfdE5vXnGwroJNOpP1f B6jkLfb7tuXrYRanLStVzTaQ7SdIlG1ifygxHPKV6DywroUTr8/zN4L4CLxL6fJjxYHQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A small rework of the PM code in this driver introduced a harmless warning when CONFIG_PM_SLEEP is not set: drivers/iio/common/hid-sensors/hid-sensor-trigger.c:212:12: error: 'hid_sensor_resume' defined but not used [-Werror=unused-function] This removes the #ifdef and instead marks all three PM functions as __maybe_unused, which covers all possible cases and is harder to get wrong. Signed-off-by: Arnd Bergmann Fixes: 7f6cf7414538 ("iio: hid-sensors: use asynchronous resume") --- drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c index 5264ed6e03e5..a3cce3a38300 100644 --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c @@ -199,8 +199,7 @@ error_ret: } EXPORT_SYMBOL(hid_sensor_setup_trigger); -#ifdef CONFIG_PM -static int hid_sensor_suspend(struct device *dev) +static int __maybe_unused hid_sensor_suspend(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); struct iio_dev *indio_dev = platform_get_drvdata(pdev); @@ -209,7 +208,7 @@ static int hid_sensor_suspend(struct device *dev) return _hid_sensor_power_state(attrb, false); } -static int hid_sensor_resume(struct device *dev) +static int __maybe_unused hid_sensor_resume(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); struct iio_dev *indio_dev = platform_get_drvdata(pdev); @@ -218,7 +217,7 @@ static int hid_sensor_resume(struct device *dev) return 0; } -static int hid_sensor_runtime_resume(struct device *dev) +static int __maybe_unused hid_sensor_runtime_resume(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); struct iio_dev *indio_dev = platform_get_drvdata(pdev); @@ -226,8 +225,6 @@ static int hid_sensor_runtime_resume(struct device *dev) return _hid_sensor_power_state(attrb, true); } -#endif - const struct dev_pm_ops hid_sensor_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(hid_sensor_suspend, hid_sensor_resume) SET_RUNTIME_PM_OPS(hid_sensor_suspend, -- 2.9.0