From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754073AbcHZPwJ (ORCPT ); Fri, 26 Aug 2016 11:52:09 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:64400 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753837AbcHZPwI (ORCPT ); Fri, 26 Aug 2016 11:52:08 -0400 From: Arnd Bergmann To: Mark Brown Cc: Arnd Bergmann , Liam Girdwood , Heiko Stuebner , Xing Zheng , Sjoerd Simons , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: rockchip: use SPI dependency for rt5514 Date: Fri, 26 Aug 2016 17:50:55 +0200 Message-Id: <20160826155120.1162512-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:zFPiTOSOKnFhJtFbaAqQwbW6h3r+CV2kOBR9x2A+gwH9Xrhm4Dq I5COhD+U6iw5Cr8pS96wZ5+z1uBv7mHO47cXSgrouSfF/eQWbJxaRDWyowmT4WUoL6i5U2o nBl+aWzhEVF+6AjdV7fY0vE1i55rIvwXxH1r2JgxWF586/QKAt+0MwOl5fo7/b5e+PCav5x 1iaQ8LzWq1mnwdqDcYEmQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:wI2c0sgWLUk=:4SCFB2QZGea5Ei7Uwf2+4N RIR9e4yog59ihDw3Fez7ikZ3gI5TAUWYJl59jRysKDGDmXQ0rTfb7if337ThlgHAH6YKHJr3D jSdiBCek9kGCZ4LLE0hNNqI+1/xFzW1nHdVCrKDD3LiQRl/0In7EEkp4jLWnOsn+xxWo3VeYE 8d8TPZPGzvwBq2zsUsfeI/mRzjgXVfaj5p/yd/rOkB3gIu7OLenFxQY+I1Lsvp3UL4X3VApuq LlY9wWFPhfPa7XIx1YLJCqROdoE2RP3q7/75YlJTXIy6BkRdpzodsaKdVM9BTJ1k8zUfXpPtx 2zx/PI72fqETAyeUXmqIlWkeAleDwj9ydWHsSVJo1cVhK6J5q/GOBEOqaRZo3l9s+FP0PzP9z XVD1JPWBfxsnLiHoxeuu2U5sNaJoN4c4wmEhc/9+UjKN4D5fdXg4BKSPznZ9+YU+7G8PKrPA4 ouhrfD07qMeQANrCGfE7q1x8ARTDQjEfAqbDLicPX3kItamu8w4+n7avlj1Xu04J1Imufu8wp R9m9BrIc3MnJtIqmZBL2BitgaBPMcl7zEELZ1Dnu9tikQR/6u7JXiegeGs5cQosguM8HoheFL YMyotI3DMG7VV5DNCKGAZ4SV5sGHhL7QGZEPpvoYsUo4pcZETGuZT5eYjS9+UuqBCpIY7Xra8 QqaUdA0E8Fa+axdO+wcXcR50HOy/VjJ6IdvFO9dXgNrMHpwTZZShGwTg0LuvS5JfOLnU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rk3399 scans the spi_bus_type to find the rt5514 driver, but does not actually have a Kconfig dependency on SPI, so we can end up with a link failure: sound/soc/codecs/snd-soc-rt5514-spi.o: In function `rt5514_spi_driver_init': rt5514-spi.c:(.init.text+0x14): undefined reference to `__spi_register_driver' sound/soc/codecs/snd-soc-rt5514-spi.o: In function `rt5514_spi_burst_read': rt5514-spi.c:(.text.rt5514_spi_burst_read+0x18c): undefined reference to `spi_sync' sound/soc/codecs/snd-soc-rt5514-spi.o: In function `rt5514_spi_burst_write': rt5514-spi.c:(.text.rt5514_spi_burst_write+0x1b4): undefined reference to `spi_sync' sound/soc/rockchip/snd-soc-rk3399-gru-sound.o: In function `rockchip_sound_probe': rk3399_gru_sound.c:(.text.rockchip_sound_probe+0x128): undefined reference to `spi_bus_type' This adds the missing dependency. Signed-off-by: Arnd Bergmann Fixes: c6eac8a36a84 ("ASoC: rockchip: Add machine driver for RK3399 GRU Boards") --- sound/soc/rockchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig index d82d763d4854..c783f9a22595 100644 --- a/sound/soc/rockchip/Kconfig +++ b/sound/soc/rockchip/Kconfig @@ -44,7 +44,7 @@ config SND_SOC_ROCKCHIP_RT5645 config SND_SOC_RK3399_GRU_SOUND tristate "ASoC support multiple codecs for Rockchip RK3399 GRU boards" - depends on SND_SOC_ROCKCHIP && I2C && GPIOLIB && CLKDEV_LOOKUP + depends on SND_SOC_ROCKCHIP && I2C && GPIOLIB && CLKDEV_LOOKUP && SPI select SND_SOC_ROCKCHIP_I2S select SND_SOC_MAX98357A select SND_SOC_RT5514 -- 2.9.0