From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754874AbcHZRE7 (ORCPT ); Fri, 26 Aug 2016 13:04:59 -0400 Received: from mail.kernel.org ([198.145.29.136]:52816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754835AbcHZRE5 (ORCPT ); Fri, 26 Aug 2016 13:04:57 -0400 Date: Fri, 26 Aug 2016 10:04:55 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: Re: [PATCH 2/2] f2fs: fix to update node page under cp_rwsem Message-ID: <20160826170455.GB88444@jaegeuk> References: <1472228072-4555-1-git-send-email-chao@kernel.org> <1472228072-4555-2-git-send-email-chao@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472228072-4555-2-git-send-email-chao@kernel.org> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 27, 2016 at 12:14:32AM +0800, Chao Yu wrote: > From: Chao Yu > > Update node page under cp_rwsem in order to keep data consistency > during writting checkpoint. > > Signed-off-by: Chao Yu > --- > fs/f2fs/inode.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index 9ac5efc..1057c73 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -377,8 +377,11 @@ retry: > goto retry; > } > > - if (err) > + if (err) { > + f2fs_lock_op(sbi); > update_inode_page(inode); > + f2fs_unlock_op(sbi); > + } Any corner case? Now, it allows updating node page when checkpoint is doing. Thanks, > sb_end_intwrite(inode->i_sb); > no_delete: > stat_dec_inline_xattr(inode); > -- > 2.7.2