From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752296AbcH0MH2 (ORCPT ); Sat, 27 Aug 2016 08:07:28 -0400 Received: from isilmar-4.linta.de ([136.243.71.142]:44516 "EHLO isilmar-4.linta.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118AbcH0MGH (ORCPT ); Sat, 27 Aug 2016 08:06:07 -0400 Date: Sat, 27 Aug 2016 14:05:22 +0200 From: Dominik Brodowski To: Russell King Cc: linux-pcmcia@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pcmcia: ds: fix suspend/resume Message-ID: <20160827120522.GA3933@light.dominikbrodowski.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Russell, On Sun, Aug 21, 2016 at 12:05:30AM +0100, Russell King wrote: > PCMCIA suspend/resume no longer works since the commit mentioned below, > as the callbacks are no longer made. Convert the driver to the new > dev_pm_ops, which restores the suspend/resume functionality. Tested on > the arm arch Assabet platform with a pcnet_cs CF card. > > Fixes: aa8e54b559479 ("PM / sleep: Go direct_complete if driver has no callbacks") > Signed-off-by: Russell King Looks goot to me. Can you push it upstream, please? Best Dominik