From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752706AbcH0MnB (ORCPT ); Sat, 27 Aug 2016 08:43:01 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:41719 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbcH0MnA (ORCPT ); Sat, 27 Aug 2016 08:43:00 -0400 Date: Sat, 27 Aug 2016 13:42:51 +0100 From: Russell King - ARM Linux To: Dominik Brodowski Cc: linux-pcmcia@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pcmcia: ds: fix suspend/resume Message-ID: <20160827124251.GZ1041@n2100.armlinux.org.uk> References: <20160827120522.GA3933@light.dominikbrodowski.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160827120522.GA3933@light.dominikbrodowski.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 27, 2016 at 02:05:22PM +0200, Dominik Brodowski wrote: > Russell, > > On Sun, Aug 21, 2016 at 12:05:30AM +0100, Russell King wrote: > > PCMCIA suspend/resume no longer works since the commit mentioned below, > > as the callbacks are no longer made. Convert the driver to the new > > dev_pm_ops, which restores the suspend/resume functionality. Tested on > > the arm arch Assabet platform with a pcnet_cs CF card. > > > > Fixes: aa8e54b559479 ("PM / sleep: Go direct_complete if driver has no callbacks") > > Signed-off-by: Russell King > > Looks goot to me. Can you push it upstream, please? I can do - should I take that as an Acked-by? Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.