From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105AbcH0OuF (ORCPT ); Sat, 27 Aug 2016 10:50:05 -0400 Received: from outbound1a.ore.mailhop.org ([54.213.22.21]:31469 "EHLO outbound1a.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752054AbcH0OuD (ORCPT ); Sat, 27 Aug 2016 10:50:03 -0400 X-MHO-User: 90f847d3-6c65-11e6-b68f-d7e0fd28072a X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 74.99.77.15 X-Mail-Handler: DuoCircle Outbound SMTP X-DKIM: OpenDKIM Filter v2.6.8 io B64938004B Date: Sat, 27 Aug 2016 14:49:58 +0000 From: Jason Cooper To: LABBE Corentin Cc: mpm@selenic.com, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/8] hwrng: amd: rework of the amd hwrng driver Message-ID: <20160827144958.GL10637@io.lakedaemon.net> References: <1472209896-17197-1-git-send-email-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472209896-17197-1-git-send-email-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Corentin, On Fri, Aug 26, 2016 at 01:11:28PM +0200, LABBE Corentin wrote: > Changes since v2: > - split the latest patch in 4 > Changes since v1: > - Keep the hwrng name as "amd" > > LABBE Corentin (8): > hwrng: amd: Fix style problem with blank line > hwrng: amd: use the BIT macro > hwrng: amd: Be consitent with the driver name > hwrng: amd: Remove asm/io.h > hwrng: amd: release_region must be called after hwrng_unregister > hwrng: amd: Replace global variable with private struct > hwrng: amd: Access hardware via ioread32/iowrite32 > hwrng: amd: Convert to new hwrng read() API > > drivers/char/hw_random/amd-rng.c | 150 +++++++++++++++++++++++++-------------- > 1 file changed, 96 insertions(+), 54 deletions(-) Once you've fixed up the casting in #6, you can add my Reviewed-by: Jason Cooper to the series. thx, Jason.