From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757113AbcH2LJi (ORCPT <rfc822;w@1wt.eu>);
        Mon, 29 Aug 2016 07:09:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55434 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1756125AbcH2LJg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 29 Aug 2016 07:09:36 -0400
Date: Mon, 29 Aug 2016 13:09:26 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Jean-Pierre Lozi <jplozi@unice.fr>,
        Jirka Hladky <jhladky@redhat.com>,
        Petr =?iso-8859-1?Q?Sur=FD?= <psury@redhat.com>,
        lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86/topology: Fallback to SMT level only once
Message-ID: <20160829110926.GB32481@krava>
References: <1472408386-5254-1-git-send-email-jolsa@kernel.org>
 <20160829104047.GH10153@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160829104047.GH10153@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.7.0 (2016-08-17)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 29 Aug 2016 11:09:28 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 29, 2016 at 12:40:47PM +0200, Peter Zijlstra wrote:
> On Sun, Aug 28, 2016 at 08:19:46PM +0200, Jiri Olsa wrote:
> > Jirka, Peter and Jean-Pierre reported performance drop on
> > some cpus after making cpu offline and online again.
> > 
> > The reason is the kernel logic that falls back to SMT
> > level topology if more than one node is detected within
> > CPU package. During the system boot this logic cuts out
> > the DIE topology level and numa code adds NUMA level
> > on top of this.
> 
> Its not SMT topology, and back when I asked if he had CoD enabled or
> such he said not.
> 
> 
> See also:
> 
> http://lkml.kernel.org/r/1471559812-19967-3-git-send-email-srinivas.pandruvada@linux.intel.com
> 
> Arguably, that should have been split in two patches, but alas..

ok, that change will work for us as well

are you going to pull it?

thanks,
jirka