From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755422AbcH2Omp (ORCPT ); Mon, 29 Aug 2016 10:42:45 -0400 Received: from mail.skyhub.de ([78.46.96.112]:56728 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756977AbcH2OmG (ORCPT ); Mon, 29 Aug 2016 10:42:06 -0400 Date: Mon, 29 Aug 2016 15:41:23 +0200 From: Borislav Petkov To: Pavel Machek Cc: Chen Yu , linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, Lee@nazgul.tnic, Chun-Yi Subject: Re: [PATCH][v8] PM / hibernate: Verify the consistent of e820 memory map by md5 value Message-ID: <20160829134123.GA28806@nazgul.tnic> References: <1472402140-959-1-git-send-email-yu.c.chen@intel.com> <20160829045942.GA6163@nazgul.tnic> <20160829071500.GA3859@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160829071500.GA3859@amd> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 29, 2016 at 09:15:00AM +0200, Pavel Machek wrote: > Sounds about as easy as hot unplugging arbitrary memory address. IOW > "not easy". Regardless, forcibly panicking the system more is still the wrong approach IMO. Instead, I'd try to issue a big fat warning that BIOS corrupts E820 and that the user should disable hibernation on that box and never ever enable it again. After that, the kernel should *disable* hibernation for the current boot so any further hibernation runs don't even happen. Maybe even taint itself. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --